Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open get_texture_mod to lua api #10338

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Open get_texture_mod to lua api #10338

merged 1 commit into from
Aug 27, 2020

Conversation

karamel59
Copy link
Contributor

get_texture_mod is listed in the lua api doc and the code is there, but it is not callable.

SmallJoker
SmallJoker approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Interesting.

@SmallJoker SmallJoker added One approval ✅ ◻️ Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines labels Aug 27, 2020
@paramat
Copy link
Contributor

paramat commented Aug 27, 2020

Commit c57b4ff
PR #5041
It seems something was forgotten but no-one tested the 'get' and no-one has used it =D

@SmallJoker SmallJoker merged commit d052593 into minetest:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmallJoker SmallJoker SmallJoker approved these changes

Assignees
No one assigned
Labels
One approval ✅ ◻️ @ Script API Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@karamel59 @paramat @SmallJoker