Add model[] formspec element #10320

SmallJoker · 2020-08-24T13:02:43Z

Copypasta from #10261 because I see potential in this feature.

To do

This PR is Ready for Review.

How to test

Devtest world
/test_formspec

Andrey2470T · 2020-08-24T13:04:02Z

XD. I have just created the same PR, too.

Includes minor code style changes.

1) Get rid of static 'rotation_bound' 2) Shorten and tweak the documentation a bit 3) Rename to "model[]" 4) Correct devtest, add license

src/gui/guiFormSpecMenu.cpp

doc/lua_api.txt

src/gui/guiScene.h

src/gui/guiScene.cpp

doc/lua_api.txt

src/gui/guiFormSpecMenu.cpp

SmallJoker · 2020-08-25T18:36:06Z

PS: Ready for re-review.

src/gui/guiFormSpecMenu.cpp

pyrollo

This is a good start with current formspec version and clearly sufficient to see how it will be used in mods.

I see a lot of future possibilities. But having a JSON or table formspec parser would be much better to handle multiple needed options:

x, y and z initial rotation;
x, y and z rotation speed;
x, y and z rotation limitations;
frame or sequence picking (use still character model, or show only the walk...);
mouse events, drag and drop...

src/gui/guiFormSpecMenu.cpp

pyrollo · 2020-08-29T15:58:17Z

src/gui/guiFormSpecMenu.cpp

+ if (vec_rot.size() >= 2)
+ e->setRotation(v2f(stof(vec_rot[0]), stof(vec_rot[1])));
+
+ e->enableContinuousRotation(inf_rotation);


It could be great to be able to control rotation speed around three axes. Anyway, I thinks it's good for now and that could be implemented later with future table or JSON formspec parser.

pyrollo · 2020-08-29T16:10:33Z

src/gui/guiScene.cpp

+ m_last_time = new_time;
+
+ core::rect<s32> oldViewPort = m_driver->getViewPort();
+ m_driver->setViewPort(getAbsoluteClippingRect());


This causes some unintended size reduction of the model if element clipped. It could be weird in scrollable containers.
Scene should be drawn in a view port sized as AbsoluteRect and clipped to getAbsoluteClippingRect(), a bit like in drawItemStack.

Could you please update the code according to your plans? I don't know what to do there.

Seems a bit more complicated than I thought. I'm having a look.

rubenwardy · 2020-08-29T17:12:49Z

But having a JSON or table formspec parser would be much better to handle multiple needed options:

Could use properties for this, ie: key-value like used by style[]

pyrollo · 2020-08-31T13:29:32Z

style[] is going to be the next language for Minetest GUI development :)

rubenwardy · 2020-08-31T14:39:33Z

Soon it'll be turing complete

Andrey2470T · 2020-09-14T06:50:03Z

Hmm, is it already commit-finished and therefore ready for merging?

Andrey2470T · 2020-09-26T11:52:49Z

Please, don't leave and merge it if it is ready for now. I'm so eager to see this feature already in the game engine.

v-rob

I'm having a weird issue (on Windows) where, when using the devtest formspec, the game will segfault if both models are present at the same time, but only when this was the first world to be entered after opening the Minetest window. If one model is removed, it works fine, and if the other model is added back in without closing the Minetest window after using the one model, no segfault occurs. It's very strange.

I'm no expert on the model stuff, but it looks OK. If this segfault issue (whatever it is) and pyrollo's model reduction issue are addressed, then 👍.

src/gui/guiScene.cpp

kilbith · 2020-10-06T19:42:40Z

the game will segfault if both models are present at the same time

Cannot reproduce (with my previous PR code).

pyrollo's model reduction issue

Offset-ing the mesh when the element is clipped is easy but the camera position is necessarily centered inside the element bounds (thus the model must also be centered to have consistent rotation). I see 2 solutions:

Leave it as is. I don't see the point to let the possibility to show a cut-off view of the model while having full camera control.
Overriding the behavior of updateAbsolutePosition called in setNotClipped

v-rob · 2020-10-06T20:57:16Z

Leave it as is. I don't see the point to let the possibility to show a cut-off view of the model while having full camera control.

Unfortunately, not really an option. The current behaviour would be weird with scroll_container because the model would move around when scrolling. Perhaps temporarily setting the rect to the not clipped size each frame, setting the camera position, and then resetting the rect before drawing would work, but I really don't know how the 3D code actually works.

Cannot reproduce (with my previous PR code).

With this current PR, I have had the problem on both Windows and Linux. So, it's probably newly introduced.

SmallJoker · 2020-10-07T14:24:17Z

With this current PR, I have had the problem on both Windows and Linux. So, it's probably newly introduced.

Could you please provide a gdb/windbg backtrace? I didn't experience any segfault with this branch.

src/gui/guiFormSpecMenu.cpp

SmallJoker · 2020-10-11T10:26:33Z

Thanks for the review. I updated and retested the PR accordingly.

v-rob · 2020-10-11T20:23:05Z

OK, it has my approval if @pyrollo's issue can be addressed. If it actually is impossible to fix (that seems unlikely, but I'm no expert), then I'll still approve.

v-rob · 2020-11-04T19:41:51Z

I'm just going to say that waiting for a solution to the clipping problem really isn't too important. It may look funny in scroll containers for now, but I think the benefits outweigh the problem. So, 👍

ghost · 2020-11-07T08:28:19Z

I check it. Some problems:

The "3d_armor_character.b3d" of the 3d_armor mod is blank textured. I think because of transparencies = not set the textures as a table.
A chance to set the loop frames range for entities, so set the pose animation?

kilbith · 2020-11-07T13:08:55Z

That's because you're a bad modder.

model[0.5,6;4,4;m1;3d_armor_character.b3d;testformspec_character.png,3d_armor_trans.png^3d_armor_helmet_diamond.png^3d_armor_chestplate_diamond.png^3d_armor_boots_diamond.png^3d_armor_leggings_diamond.png,default_chest_front.png]

kthxbye.

ghost · 2020-11-08T09:01:34Z

That's because you're a bad modder.

model[0.5,6;4,4;m1;3d_armor_character.b3d;testformspec_character.png,3d_armor_trans.png^3d_armor_helmet_diamond.png^3d_armor_chestplate_diamond.png^3d_armor_boots_diamond.png^3d_armor_leggings_diamond.png,default_chest_front.png]

kthxbye.

stop fooling around and fix the animations.

Thankz.

SmallJoker · 2020-11-08T10:17:44Z

@runsy Please open a new bug report for the transparency issue and a new feature request for the frame range thing.

ghost · 2020-11-08T13:29:12Z

@runsy Please open a new bug report for the transparency issue and a new feature request for the frame range thing.
The transparency thing was not an issue.

I did it:
#10615
#10614

@kilbith

Formspec element to display models, written by @kilbith, rebased and tweaked. Co-authored-by: Jean-Patrick Guerrero <[email protected]> Co-authored-by: sfan5 <[email protected]>

SmallJoker added @ Script API Feature ✨ PRs that add or enhance a feature labels Aug 24, 2020

Jean-Patrick Guerrero and others added 3 commits August 24, 2020 15:06

GUIFormspecMenu: Add mesh element

fad9679

Includes minor code style changes.

Re-attempt to fix MinGW/MSVC

c7f9d8a

Address comments...

fbb8f35

1) Get rid of static 'rotation_bound' 2) Shorten and tweak the documentation a bit 3) Rename to "model[]" 4) Correct devtest, add license

SmallJoker force-pushed the guiscene2 branch from a6ab8f0 to fbb8f35 Compare August 24, 2020 13:08

pyrollo mentioned this pull request Aug 24, 2020

[FormSpec] Add 'mesh' element. #10319

Closed

rubenwardy added the One approval ✅ ◻️ label Aug 24, 2020

Desour reviewed Aug 24, 2020

View reviewed changes

src/gui/guiFormSpecMenu.cpp Outdated Show resolved Hide resolved

Desour reviewed Aug 24, 2020

View reviewed changes

doc/lua_api.txt Outdated Show resolved Hide resolved

rubenwardy reviewed Aug 24, 2020

View reviewed changes

src/gui/guiScene.h Outdated Show resolved Hide resolved

rubenwardy reviewed Aug 24, 2020

View reviewed changes

src/gui/guiScene.cpp Outdated Show resolved Hide resolved

Andrey2470T reviewed Aug 24, 2020

View reviewed changes

doc/lua_api.txt Show resolved Hide resolved

SmallJoker removed the One approval ✅ ◻️ label Aug 24, 2020

Further cleanups. Controllde rotation speed, etc

2dcc796

Andrey2470T reviewed Aug 24, 2020

View reviewed changes

src/gui/guiFormSpecMenu.cpp Outdated Show resolved Hide resolved

paramat added the Formspec label Aug 24, 2020

Andrey2470T reviewed Aug 27, 2020

View reviewed changes

src/gui/guiFormSpecMenu.cpp Show resolved Hide resolved

pyrollo reviewed Aug 29, 2020

View reviewed changes

Add name, test mouse interaction

bcb6fe1

rubenwardy requested review from pyrollo and v-rob September 26, 2020 14:37

v-rob reviewed Oct 6, 2020

View reviewed changes

src/gui/guiScene.cpp Outdated Show resolved Hide resolved

src/gui/guiScene.cpp Outdated Show resolved Hide resolved

v-rob reviewed Oct 10, 2020

View reviewed changes

src/gui/guiFormSpecMenu.cpp Outdated Show resolved Hide resolved

Handle comments

5e8e674

v-rob mentioned this pull request Oct 27, 2020

CSM Events and Drawing Testing #10524

Closed

v-rob added the One approval ✅ ◻️ label Nov 4, 2020

SmallJoker merged commit 3356da0 into minetest:master Nov 4, 2020

SmallJoker deleted the guiscene2 branch June 4, 2022 19:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add model[] formspec element #10320

Add model[] formspec element #10320

SmallJoker commented Aug 24, 2020

Andrey2470T commented Aug 24, 2020

SmallJoker commented Aug 25, 2020

pyrollo left a comment

pyrollo Aug 29, 2020

pyrollo Aug 29, 2020

SmallJoker Sep 2, 2020

pyrollo Sep 6, 2020

rubenwardy commented Aug 29, 2020

pyrollo commented Aug 31, 2020

rubenwardy commented Aug 31, 2020

Andrey2470T commented Sep 14, 2020

Andrey2470T commented Sep 26, 2020

v-rob left a comment •

edited

Loading

kilbith commented Oct 6, 2020 •

edited

Loading

v-rob commented Oct 6, 2020 •

edited

Loading

SmallJoker commented Oct 7, 2020

SmallJoker commented Oct 11, 2020

v-rob commented Oct 11, 2020

v-rob commented Nov 4, 2020

ghost commented Nov 7, 2020 •

edited by ghost

Loading

kilbith commented Nov 7, 2020

ghost commented Nov 8, 2020 •

edited by ghost

Loading

SmallJoker commented Nov 8, 2020

ghost commented Nov 8, 2020 •

edited by ghost

Loading

Add model[] formspec element #10320

Add model[] formspec element #10320

Conversation

SmallJoker commented Aug 24, 2020

To do

How to test

Andrey2470T commented Aug 24, 2020

SmallJoker commented Aug 25, 2020

pyrollo left a comment

Choose a reason for hiding this comment

pyrollo Aug 29, 2020

Choose a reason for hiding this comment

pyrollo Aug 29, 2020

Choose a reason for hiding this comment

SmallJoker Sep 2, 2020

Choose a reason for hiding this comment

pyrollo Sep 6, 2020

Choose a reason for hiding this comment

rubenwardy commented Aug 29, 2020

pyrollo commented Aug 31, 2020

rubenwardy commented Aug 31, 2020

Andrey2470T commented Sep 14, 2020

Andrey2470T commented Sep 26, 2020

v-rob left a comment • edited Loading

Choose a reason for hiding this comment

kilbith commented Oct 6, 2020 • edited Loading

v-rob commented Oct 6, 2020 • edited Loading

SmallJoker commented Oct 7, 2020

SmallJoker commented Oct 11, 2020

v-rob commented Oct 11, 2020

v-rob commented Nov 4, 2020

ghost commented Nov 7, 2020 • edited by ghost Loading

kilbith commented Nov 7, 2020

ghost commented Nov 8, 2020 • edited by ghost Loading

SmallJoker commented Nov 8, 2020

ghost commented Nov 8, 2020 • edited by ghost Loading

v-rob left a comment •

edited

Loading

kilbith commented Oct 6, 2020 •

edited

Loading

v-rob commented Oct 6, 2020 •

edited

Loading

ghost commented Nov 7, 2020 •

edited by ghost

Loading

ghost commented Nov 8, 2020 •

edited by ghost

Loading

ghost commented Nov 8, 2020 •

edited by ghost

Loading