Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MSVC compiler warnings #10197

Merged
merged 1 commit into from
Aug 23, 2020
Merged

Fix MSVC compiler warnings #10197

merged 1 commit into from
Aug 23, 2020

Conversation

adrido
Copy link
Contributor

@adrido adrido commented Jul 18, 2020

Fix some warnings on msvc

To do

This PR is Ready for Review.

How to test

Watch the GitHub actions build-bot

@SmallJoker SmallJoker added Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements Windows labels Jul 18, 2020
SmallJoker
SmallJoker approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cut/Copy on Linux is broken the same way as in master. Nothing worsened. Code looks good.

@SmallJoker SmallJoker added One approval ✅ ◻️ Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines labels Aug 19, 2020
@SmallJoker SmallJoker merged commit 3c28906 into minetest:master Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmallJoker SmallJoker SmallJoker approved these changes

Assignees
No one assigned
Labels
Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️ Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adrido @SmallJoker