Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Could NOT find JSONCPP (missing: JSON_INCLUDE_DIR) #9119

Closed
vilhelmgray opened this issue Nov 16, 2019 · 0 comments · Fixed by #9120
Closed

Could NOT find JSONCPP (missing: JSON_INCLUDE_DIR) #9119

vilhelmgray opened this issue Nov 16, 2019 · 0 comments · Fixed by #9120
Labels
Bug Issues that were confirmed to be a bug @ Build CMake, build scripts, official builds, compiler and linker errors

Comments

@vilhelmgray
Copy link
Contributor

Issue discovered on Gentoo (https://bugs.gentoo.org/700220) but occurs on latest vanilla Minetest 5.1.0 release.

The upstream JSONCPP project has renamed the json/features.h file to json/json_features.h: open-source-parsers/jsoncpp#1024

This causes newer versions of JSONCPP to not be found by the Minetest FindJson.cmake module. The following line should be changed to search for a different json header file:

minetest/cmake/Modules/FindJson.cmake

Line 11 in 49365b2

find_path(JSON_INCLUDE_DIR json/features.h PATH_SUFFIXES jsoncpp)

@vilhelmgray vilhelmgray added the Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible label Nov 16, 2019
@sfan5 sfan5 added @ Build CMake, build scripts, official builds, compiler and linker errors Bug Issues that were confirmed to be a bug and removed Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible labels Nov 16, 2019
vilhelmgray added a commit to vilhelmgray/minetest that referenced this issue Nov 16, 2019
@vilhelmgray
Fix find_path for newer jsoncpp installations
55dfbe2 
The upstream JsonCpp project has renamed the `json/features.h` file to
`json/json_features.h`. This patch fixes the JsonCpp installation search
by looking for `json/allocator.h` which has not been renamed on newer
versions of JsonCpp.

Fixes: minetest#9119
@vilhelmgray vilhelmgray mentioned this issue Nov 16, 2019
Merged
sfan5 pushed a commit that referenced this issue Nov 17, 2019
@vilhelmgray @sfan5
Fix find_path for newer jsoncpp installations
706b6aa 
The upstream JsonCpp project has renamed the `json/features.h` file to
`json/json_features.h`. This patch fixes the JsonCpp installation search
by looking for `json/allocator.h` which has not been renamed on newer
versions of JsonCpp.

Fixes: #9119
rubenwardy pushed a commit that referenced this issue Dec 31, 2019
@vilhelmgray @rubenwardy
Fix find_path for newer jsoncpp installations
5e4739b 
The upstream JsonCpp project has renamed the `json/features.h` file to
`json/json_features.h`. This patch fixes the JsonCpp installation search
by looking for `json/allocator.h` which has not been renamed on newer
versions of JsonCpp.

Fixes: #9119
aldum pushed a commit to banyamesterseg/minetest that referenced this issue Apr 16, 2020
@vilhelmgray @aldum
Fix find_path for newer jsoncpp installations
7265803 
The upstream JsonCpp project has renamed the `json/features.h` file to
`json/json_features.h`. This patch fixes the JsonCpp installation search
by looking for `json/allocator.h` which has not been renamed on newer
versions of JsonCpp.

Fixes: minetest#9119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Issues that were confirmed to be a bug @ Build CMake, build scripts, official builds, compiler and linker errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix find_path for newer jsoncpp installations vilhelmgray/minetest
2 participants
@sfan5 @vilhelmgray