..

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+# Unreleased
+
+### Added
+
+- Add default flash notice for sign out (#178)
+
 ## 1.0.1
 
 ### Fixed

app/controllers/passwordless/sessions_controller.rb

@@ -99,11 +99,11 @@ def confirm
  def destroy
  sign_out(authenticatable_class)
 
- redirect_to_response_options = {
- notice: I18n.t("passwordless.sessions.destroy.signed_out")
- }.merge(redirect_to_options)
-
- redirect_to(passwordless_sign_out_redirect_path, redirect_to_response_options)
+ redirect_to(
+ passwordless_sign_out_redirect_path,
+  notice: I18n.t("passwordless.sessions.destroy.signed_out"),
+ **redirect_to_options
+ )
  end
 
  protected

test/controllers/passwordless/sessions_controller_test.rb

@@ -196,29 +196,15 @@ class << User
 
  assert_equal 200, status
  assert_equal "/", path
- assert_match I18n.t("passwordless.sessions.destroy.signed_out"), flash[:notice]
+ assert_match "Signed out successfully", flash[:notice]
  assert pwless_session(User).blank?
  end
 
  test("DELETE /:passwordless_for/sign_out :: When response options are configured ") do
- Passwordless.configure do |config|
- config.redirect_to_response_options = {
- notice: "my custom notice"
- }
+ with_config(redirect_to_response_options: {notice: "my custom notice"}) do
+ get "/users/sign_out"
+ assert_match "my custom notice", flash[:notice]
  end
-
- user = User.create(email: "a@a")
- passwordless_session = create_pwless_session(authenticatable: user, token: "hi")
-
- get "/users/sign_in/#{passwordless_session.id}/#{passwordless_session.token}"
- assert_not_nil pwless_session(User)
-
- get "/users/sign_out"
- follow_redirect!
-
- assert_equal 200, status
- assert pwless_session(User).blank?
- assert_match "my custom notice", flash[:notice]
  end
 
  class Helpers