Add default flash notice on SessionsController#destroy #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a default flash notice to destroy action while also keeping the flexibility to customize redirect options via config. When creating a session in case of success there is a flash notice displayed while when destroying a session there was not flash noticed displayed in case of success. Also having a successful flash message for destroying a session makes the system tests in the apps using this gem a bit easier to check if the logout happened successfully.
|
❤️🧡💛💚💙💜 |
|
heyy @lucianghinda nice to see you here! 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This commit adds a default flash notice to destroy action while keeping the flexibility to customize redirect options via config.
Why
When creating a session in case of success, a flash notice is displayed, while when destroying a session, there was no flash notice displayed in case of success.
Also, having a successful flash message for destroying a session makes the system tests in the apps using this gem a bit easier to check if the logout happened successfully.