Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/fix: move logic into setup phase and correct order #88

Merged
merged 5 commits into from
Dec 22, 2021

Commits on Dec 21, 2021

  1. refactor: move logic into setup phase

    When the plugin started out, I didn't know how to use the
    `runtest_setup` phase, so I used an automatically-used fixture.
    
    Once the hook usage was introduced, I can now consolidate a lot of the
    behavior logic ion one place.
    
    Signed-off-by: Mike Fiedler <[email protected]>
    miketheman committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    7d5de67 View commit details
    Browse the repository at this point in the history
  2. test: add precedence test

    May duplicate some of the other tests, but I wanted to make sure this
    was clear.
    I may refactor other tests later - it's unclear how to measure how many
    times a line is hit right now.
    
    Signed-off-by: Mike Fiedler <[email protected]>
    miketheman committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    6623a82 View commit details
    Browse the repository at this point in the history
  3. fix: address conflict with configurations

    The previous configuration allowed for `allow-hosts` to be passed
    without `--disable-socket` to implicitly activate blocking.
    
    This was confusing and inconsistent so we now require it to enable the
    global behavior.
    
    This introduces a little more complexity to the setup method, but is
    more clear as to what is actually happening.
    
    Signed-off-by: Mike Fiedler <[email protected]>
    miketheman committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    e4fff1a View commit details
    Browse the repository at this point in the history
  4. test: remove test covered by test_async

    Signed-off-by: Mike Fiedler <[email protected]>
    miketheman committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    d99a622 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2021

  1. refactor: extract complexity

    Signed-off-by: Mike Fiedler <[email protected]>
    miketheman committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    d3d8e0f View commit details
    Browse the repository at this point in the history