refactor/fix: move logic into setup phase and correct order #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the plugin started out, I didn't know how to use the
runtest_setup
phase, so I used an automatically-used fixture.I've now removed the fixture, which may have had unintended side effects with other plugins or test suites.
I've also changed the ordering, to be more inline with the expected behaviors, as I laid out in #81 (comment)
I've added a bunch of tests that express the desired precedence behavior in a test module
tests/test_precedence.py
and all the existing tests pass as well 🎉 .This, and a few other bits, should lead to an 0.50.0 release.
Signed-off-by: Mike Fiedler [email protected]