Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inno setup - Switch from commondesktop to autodesktop #105006

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Inno setup - Switch from commondesktop to autodesktop #105006

merged 1 commit into from
Aug 19, 2020

Conversation

lszomoru
Copy link
Member

This PR fixes #104545

@lszomoru lszomoru added install-update VS Code installation and upgrade system issues candidate Issue identified as probable candidate for fixing in the next release windows VS Code on Windows issues labels Aug 19, 2020
@lszomoru lszomoru added this to the July 2020 Recovery milestone Aug 19, 2020
@lszomoru lszomoru requested a review from isidorn August 19, 2020 15:36
@lszomoru lszomoru self-assigned this Aug 19, 2020
@isidorn
Copy link
Contributor

isidorn commented Aug 19, 2020

I have verified this fixes the issue.
The change also makes sense. For now optimisticaly merging.

fyi @deepak1556 for another pair of eyes.

@isidorn
Copy link
Contributor

isidorn commented Aug 19, 2020

@lszomoru for reference can you just provide a pointer for the docs where they mention the change of naming

@isidorn isidorn merged commit 3dd9051 into release/1.48 Aug 19, 2020
@isidorn isidorn deleted the lszomoru/release/1.48/setup-icon-fix branch August 19, 2020 16:42
@deepak1556
Copy link
Contributor

deepak1556 commented Aug 19, 2020 •
edited
Loading

@isidorn its in the same 6.0.0-beta as the other breaking change https://jrsoftware.org/files/is6-whatsnew.htm

Added new "auto" constants which automatically map to their "common" form unless the installation is running in
non administrative install mode, in which case they map to their "user" form. It is recommended to update
your scripts to use these "auto" constants as much as possible to avoid mistakes. The list of added "auto"
constants is: {autoappdata}, {autocf}, {autocf32}, {autocf64}, {autodesktop}, {autodocs}, {autopf},
{autopf32}, {autopf64}, {autoprograms}, {autostartmenu}, {autostartup}, and {autotemplates}.

@lszomoru
Copy link
Member Author

Forgot to mention that I also double checked and {commondesktop} was the only common constant that we are using.

@isidorn
Copy link
Contributor

isidorn commented Aug 20, 2020 •
edited
Loading

Awesome. So we are good.
@deepak1556 thanks for the pointer
@lszomoru thanks for checking other common constants

@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@isidorn isidorn isidorn approved these changes

@deepak1556 deepak1556 Awaiting requested review from deepak1556

Assignees

@lszomoru lszomoru

Labels
candidate Issue identified as probable candidate for fixing in the next release install-update VS Code installation and upgrade system issues windows VS Code on Windows issues
Projects
None yet
Milestone
July 2020 Recovery
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lszomoru @isidorn @deepak1556