-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"IPersistFile::Save failed" during installation of VS Code Insiders #104545
Comments
Windows 8.1 64 Same is happening with me, but with the stable installer (VSCodeUserSetup-x64-1.48.0.exe). |
I tried to uninstall and install again, but checked only the PATH option. All other options was left unchecked. No error happend. I don't know if was coincidence or that others checked options were causing the error. |
I believe "Create desktop shortcut" option may be producing this error. |
Same happened installing Visual Studio Code. The thing is it happened with a pretty old Windows (not that that old but quite) but it still let me download it. What does this mean then? I had no problem installing it in another more modern computer but I have no idea what is wrong here... |
I also encountered the same problem |
Same exact error, though I installed it on another PC in my network without issue- same version of Windows, same options checked. |
Same exact error, also happened during creation of the shortcut. |
Having the same issue. Been using it for over an year but never faced any issue like this. It got updated yesterday when I was working and after that when I tried to use live server, the chrome tab keeps on loading and CPU usage gets above 90% for chrome. Strange. Update: So I tried a suggestion to leave the icon option on desktop unchecked and the error did not occur this time. Somethings wrong with my PC or its a bug? Also, live server issue remains same. Can someone check if they are facing the same issue? |
create dekstop shortcut made this error ?? |
I have the same issue on Windows 7 - and seems like the checked "install link on the desktop" causes the problem, as at the end of installation VS saying "installed fine" and it's running OK. |
Users seeing this with vscode insiders when did this start happening? @bpasero for potential smartness |
Running with
in my case it is a permission issue to the folder it is trying to write the shortcut link to. Users having similar error code please check if the setup executable under your current user has permissions to write into that folder. If anyone else has a different error code, please paste the inno setup log using |
I saw this error as well when I tested the installer (using a Windows VM on Parallels 10). |
Same Issue with me today, as @Maxim-Mazurok suggested I install it again without "Creating desktop shortcut" worked and install without any errors. |
Sorry about the early conclusion, a bit more investigation looking at the logs of Looking at the changelog, the only relevant changes that went into the setup code path are 5f5b75a cbc8bd8 , will check if the change in setup style brought in this behavior. |
@deepak1556 thanks for looking into this. I have cycles so let me know if I can help somehow. |
Dear users that see this can you please try to install this insiders build and let us know if you can still reproduce. This would be very valuable to us as it contains a potential fix for this issue:
As far as I understand the issue this only happnes for the user install. If somebody sees this issue for a non user install please let us know. |
@Maxim-Mazurok thanks a lot. We figured out that it did not fix the issue. |
Here's win32 build: Soon we will have win64 |
So please try it out and let us know. What is not 100% clear to me are repro steps. It only happens with the user install that creates a desktop shortcut. Edit: yeah now the steps are 100% clear to me. |
I have verified that the Inno-updater revert of version indeed fixes the issue. |
Worked for me without any error now with Check in to create a desktop shortcut. |
Great. It also worked for me. So to recap:
We will decide on which one to do depending on the risk. fyi @lszomoru @deepak1556 |
Correct, I did check "Create desktop shortcut" Worked for me without any errors, created shortcut. Thanks! |
Thanks @Maxim-Mazurok! We have a PR with a fix that will be included in the recovery build. |
All with all options checked: VSCodeUserSetup-x64-1.48.0.exe >> error |
Verification steps:
Setup should complete successfully, and a desktop icon should be created |
Commit: db40434
Date: 2020-08-11T23:21:50.282Z
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
Steps to Reproduce:
I'm not sure if it's relevant, but I had VS stable installed prior to the Insiders install. Also, I tried to remove stable and reinstall Insiders, which resulted in the same error. It seems like everything is functioning properly, but there's no shortcut on the desktop.
Does this issue occur when all extensions are disabled?: Yes
The text was updated successfully, but these errors were encountered: