Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to new version of node-spdlog #194981

Closed
hsfzxjy opened this issue Oct 6, 2023 · 0 comments · Fixed by #196322
Closed

Bump to new version of node-spdlog #194981

hsfzxjy opened this issue Oct 6, 2023 · 0 comments · Fixed by #196322
Assignees
@sandy081
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders log VS Code log issues
Milestone
October 2023

Comments

@hsfzxjy
Copy link
Contributor

hsfzxjy commented Oct 6, 2023 •
edited
Loading

I have opened an upstream PR microsoft/node-spdlog#39 to solve issue #189716 . It's been a month since the PR merged but no new release of node-spdlog is published, nor could vscode benefit from the latest fix. I was wondering is there any plan to make progress on this issue?
@roblourens roblourens assigned deepak1556 and sandy081 and unassigned roblourens Oct 6, 2023
@deepak1556 deepak1556 removed their assignment Oct 7, 2023
@deepak1556 deepak1556 added the debt Code quality issues label Oct 7, 2023
@sandy081 sandy081 added the log VS Code log issues label Oct 11, 2023
@sandy081 sandy081 added this to the October 2023 milestone Oct 11, 2023
@sandy081 sandy081 mentioned this issue Oct 23, 2023
Merged
sandy081 added a commit that referenced this issue Oct 23, 2023
@sandy081
fix #194981
c5af2d2
sandy081 added a commit that referenced this issue Oct 23, 2023
@sandy081
fix #194981 (#196322)
7b69e4a
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 23, 2023
Alex0007 pushed a commit to Alex0007/vscode that referenced this issue Oct 26, 2023
@sandy081 @Alex0007
fix microsoft#194981 (microsoft#196322)
d1aa540
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders log VS Code log issues
Projects
None yet
Milestone
October 2023
Development

Successfully merging a pull request may close this issue.

fix #194981 microsoft/vscode
5 participants
@roblourens @deepak1556 @hsfzxjy @sandy081 @VSCodeTriageBot