Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output Pane displays partial content if the log contains character 'U+0000' #189716

Closed
hsfzxjy opened this issue Aug 5, 2023 · 1 comment · Fixed by microsoft/node-spdlog#39
Closed
Assignees

Comments

@hsfzxjy
Copy link
Contributor

hsfzxjy commented Aug 5, 2023

Type: Bug

  • VS Code Version: 1.81.0
  • OS Version: Ubuntu 20.04.6 LTS

Any extension logging through node-spdlog is affected by this bug.

For example, vscode-go runs tests and logging the stdout/stderr output to the Output Pane. If we write a piece of test code that simply outputs a string containing U+0000 to stdout,

image

then only the string "before" is logged to Output Pane and content "after" after U+0000 is trimmed.

image

This is acknowledged as a bug of node-spdlog. microsoft/node-spdlog#39 will fix it.

@hsfzxjy
Copy link
Contributor Author

hsfzxjy commented Aug 21, 2023

@sandy081 Could you spare some time to take a look at this one? It's a rather long-term critical bug but should be a quick fix with my PR. 🙏

@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants