Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Enforce prefixes for PR titles #224

Merged
merged 11 commits into from
Mar 9, 2022
Merged

ENH: Enforce prefixes for PR titles #224

merged 11 commits into from
Mar 9, 2022

Conversation

ant0nsc
Copy link
Collaborator

@ant0nsc ant0nsc commented Mar 8, 2022

Please follow the guidelines for PRs contained here. Checklist:

  • Ensure that your PR is small, and implements one change.
  • Add unit tests for all functions that you introduced or modified.
  • Run PyCharm's code cleanup tools on your Python files.
  • Ensure that documentation renders correctly in Sphinx (run Sphinx via make html in the `docs folder)
  • Link the correct GitHub issue for tracking.
  • When merging your PR, replace the default merge message with a brief description of your PR,
    and if needed a motivation why that change was required.

@ant0nsc ant0nsc linked an issue Mar 8, 2022 that may be closed by this pull request
Enforce a consistent style for PR titles #218
Closed
fepegar
fepegar requested changes Mar 8, 2022
View reviewed changes
.github/workflows/check-pr-title.yml Outdated Show resolved Hide resolved
.github/workflows/check-pr-title.yml Outdated Show resolved Hide resolved
docs/source/contributing.md Outdated Show resolved Hide resolved
pull_request_template.md Outdated Show resolved Hide resolved
pull_request_template.md Outdated Show resolved Hide resolved
pull_request_template.md Outdated Show resolved Hide resolved
pull_request_template.md Outdated Show resolved Hide resolved
pull_request_template.md Outdated Show resolved Hide resolved
pull_request_template.md Outdated Show resolved Hide resolved
fepegar
fepegar reviewed Mar 9, 2022
View reviewed changes
Copy link
Contributor

@fepegar fepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the new commit?

@fepegar
Copy link
Contributor

fepegar commented Mar 9, 2022

Why the new commit?

Oh, I see it wasn't mean to happen.

@ant0nsc ant0nsc changed the title ENH: Enforce prefixes for PR titles No prefix Enforce prefixes for PR titles Mar 9, 2022
@ant0nsc ant0nsc changed the title No prefix Enforce prefixes for PR titles ABC: Enforce prefixes for PR titles Mar 9, 2022
@ant0nsc ant0nsc changed the title ABC: Enforce prefixes for PR titles ENH: Enforce prefixes for PR titles Mar 9, 2022
fepegar
fepegar approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@fepegar fepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ant0nsc. LGTM.

@ant0nsc ant0nsc merged commit 7df1a18 into main Mar 9, 2022
@ant0nsc ant0nsc deleted the antonsc/pr_titles branch March 9, 2022 09:28
@ant0nsc ant0nsc restored the antonsc/pr_titles branch March 9, 2022 09:32
@ant0nsc ant0nsc deleted the antonsc/pr_titles branch March 18, 2022 08:34
@ant0nsc ant0nsc mentioned this pull request Mar 28, 2022
Merged
@fepegar fepegar mentioned this pull request Mar 28, 2022
Closed
@fepegar fepegar mentioned this pull request Jun 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fepegar fepegar fepegar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enforce a consistent style for PR titles
2 participants
@ant0nsc @fepegar