Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Deprecate manual changelog #707

Merged
merged 5 commits into from
Mar 29, 2022
Merged

Deprecate manual changelog #707

merged 5 commits into from
Mar 29, 2022

Conversation

fepegar
Copy link
Contributor

@fepegar fepegar commented Mar 24, 2022

This replicates what we did for hi-ml:

ant0nsc
ant0nsc previously approved these changes Mar 24, 2022
@fepegar
Copy link
Contributor Author

fepegar commented Mar 24, 2022

Something happened with nbconvert in the Hello World test. @mebristo could you please verify that it's not our fault?

@fepegar
Copy link
Contributor Author

fepegar commented Mar 25, 2022

Waiting for microsoft/hi-ml#265 to be merged.

@ant0nsc
Copy link
Contributor

ant0nsc commented Mar 25, 2022

@fepegar, hi-ml has just been updated, can you add the latest main in the submodule?

@fepegar
Copy link
Contributor Author

fepegar commented Mar 25, 2022

Waiting for #709 to be merged.

@ant0nsc
Copy link
Contributor

ant0nsc commented Mar 28, 2022

@fepegar , I think we should then also add a build step that checks if the title matches the expected rules, like we did in hi-ml in microsoft/hi-ml#224? Were you planning to do that in a separate PR?

@fepegar
Copy link
Contributor Author

fepegar commented Mar 28, 2022

@fepegar , I think we should then also add a build step that checks if the title matches the expected rules, like we did in hi-ml in microsoft/hi-ml#224? Were you planning to do that in a separate PR?

I think that's a good idea. Yes, I think we can add that after this has been merged, but I'm happy to add it here if you think it's easier.

@fepegar fepegar requested a review from ant0nsc March 29, 2022 09:42
@fepegar fepegar merged commit 3eaf2f9 into main Mar 29, 2022
@fepegar fepegar deleted the deprecate-changelog branch March 29, 2022 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants