Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable PR check debug mode by default. #9795

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

PawelWMS
Copy link
Contributor

@PawelWMS PawelWMS commented Jul 11, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Disabling running the PR check pipeline in debug mode by default. It used to be needed to figure out a build issue, which we've fixed a while ago. Now it's only causing the npm warning to appear as errors making it harder to see actual errors:
image

The team owning the component generating these warnings already has a work item for fixing this issue.
 

Does this affect the toolchain?

No.

Test Methodology
  • PR check.

@PawelWMS PawelWMS requested a review from a team as a code owner July 11, 2024 17:44
@mfrw mfrw added the fasttrack/2.0 PRs Destined for AzureLinux 2.0 label Jul 15, 2024
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@PawelWMS
Copy link
Contributor Author

Failing ptests unrelated to this change - no regressions, ready to merge.

@PawelWMS PawelWMS merged commit a26a8db into fasttrack/2.0 Aug 8, 2024
14 of 18 checks passed
@PawelWMS PawelWMS deleted the pawelwi/disable_debug branch August 8, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fasttrack/2.0 PRs Destined for AzureLinux 2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants