Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled PR check debug mode by default. (CP: #9795) #10096

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

PawelWMS
Copy link
Contributor

@PawelWMS PawelWMS commented Aug 9, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Manual cherry-pick of fast-track's #9795 - the automation pipeline broken due to infrastructure issues.

Does this affect the toolchain?

No.

Associated issues
Links to CVEs
Test Methodology

@PawelWMS PawelWMS requested a review from a team as a code owner August 9, 2024 21:46
@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label Aug 9, 2024
@PawelWMS PawelWMS added the Auto Fast-track Cherry-pick Automatic cherry-pick from fast-track branch label Aug 9, 2024
@PawelWMS PawelWMS merged commit 45be18f into main Aug 12, 2024
10 checks passed
@PawelWMS PawelWMS deleted the pawelwi/disable_debug_backport branch August 12, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto Fast-track Cherry-pick Automatic cherry-pick from fast-track branch main PR Destined for main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants