Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protobuf check section #5127

Merged
merged 23 commits into from
Aug 2, 2023
Merged

Conversation

mbykhovtsev-ms
Copy link
Contributor

@mbykhovtsev-ms mbykhovtsev-ms commented Mar 21, 2023

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

De-coupled check section addition from PR #4955.

Change Log
  • Added check sections that runs main make tests
Does this affect the toolchain?

Yes

Test Methodology

@mbykhovtsev-ms mbykhovtsev-ms requested a review from a team as a code owner March 21, 2023 00:22
@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label Mar 21, 2023
@mbykhovtsev-ms mbykhovtsev-ms force-pushed the mbykhovtsev/add-protobuf-tests branch from a1cf869 to ec9ad88 Compare June 9, 2023 20:00
@mbykhovtsev-ms mbykhovtsev-ms changed the title Add protobuf check section for main and python packages Add protobuf check section Jun 9, 2023
@mbykhovtsev-ms mbykhovtsev-ms merged commit 6e05f4f into main Aug 2, 2023
11 checks passed
@mbykhovtsev-ms mbykhovtsev-ms deleted the mbykhovtsev/add-protobuf-tests branch August 2, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants