-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-adding protobuf java subpackage and adding check section #4955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small comments but looks good in general. Thanks!
@@ -6,7 +6,7 @@ | |||
Summary: Mariner specific rpm macro files | |||
Name: mariner-rpm-macros | |||
Version: 2.0 | |||
Release: 20%{?dist} | |||
Release: 21%{?dist} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a changelog entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to add a missing changelog entry and I think we're done with this one.
Sorry I have not done any updates on this. This PR is not ready in the current state, now that we determined that we cannot vendor maven m2 as it might contain binaries. I will update this PR once we add maven tools to allow to provide dependencies via system instead of using m2 cache. |
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./SPECS/LICENSES-AND-NOTICES/data/licenses.json
,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md
,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
Adds back protobuf java subpackage, as it will be required for future packages such as Hadoop. As well as adds check section that runs built-in unit tests for the protobuf make and java subpackage.
Change Log
Does this affect the toolchain?
NO
Test Methodology