Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-adding protobuf java subpackage and adding check section #4955

Closed
wants to merge 14 commits into from

Conversation

mbykhovtsev-ms
Copy link
Contributor

@mbykhovtsev-ms mbykhovtsev-ms commented Feb 28, 2023

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Adds back protobuf java subpackage, as it will be required for future packages such as Hadoop. As well as adds check section that runs built-in unit tests for the protobuf make and java subpackage.

Change Log
  • Re-added back protobuf java subpackage. As it will be required for future packages such as Hadoop
  • Added check sections that runs main make tests and also java subpackage tests
Does this affect the toolchain?

NO

Test Methodology

@mbykhovtsev-ms mbykhovtsev-ms requested a review from a team as a code owner February 28, 2023 00:55
@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label Feb 28, 2023
SPECS/protobuf/protobuf.spec Outdated Show resolved Hide resolved
SPECS/protobuf/protobuf.spec Outdated Show resolved Hide resolved
SPECS/protobuf/protobuf.spec Outdated Show resolved Hide resolved
Copy link
Contributor

@PawelWMS PawelWMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments but looks good in general. Thanks!

@@ -6,7 +6,7 @@
Summary: Mariner specific rpm macro files
Name: mariner-rpm-macros
Version: 2.0
Release: 20%{?dist}
Release: 21%{?dist}
Copy link
Contributor

@PawelWMS PawelWMS Mar 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a changelog entry.

Copy link
Contributor

@PawelWMS PawelWMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to add a missing changelog entry and I think we're done with this one.

@mbykhovtsev-ms mbykhovtsev-ms mentioned this pull request Mar 21, 2023
12 tasks
@mbykhovtsev-ms
Copy link
Contributor Author

Sorry I have not done any updates on this. This PR is not ready in the current state, now that we determined that we cannot vendor maven m2 as it might contain binaries. I will update this PR once we add maven tools to allow to provide dependencies via system instead of using m2 cache.

@jslobodzian jslobodzian deleted the mbykhovtsev/add-protobuf-java branch September 4, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants