Allow partial matches in discrimination logic #58974

ahejlsberg · 2024-06-22T12:06:31Z

ahejlsberg · 2024-06-22T12:06:42Z

typescript-bot · 2024-06-22T12:06:46Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-06-22T12:27:00Z

Hey @ahejlsberg, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-06-22T12:36:50Z

@ahejlsberg Here are the results of running the user tests with tsc comparing main and refs/pull/58974/merge:

Everything looks good!

typescript-bot · 2024-06-22T12:42:28Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,189k (± 0.07%)}	_{192,333k (± 0.11%)}	_~	_192,103k	_192,594k	_{p=0.298 n=6}
_{Parse Time}	_{1.31s (± 0.39%)}	_{1.30s (± 1.35%)}	_~	_1.27s	_1.32s	_{p=0.504 n=6}
_{Bind Time}	_0.71s	_{0.71s (± 0.57%)}	_~	_0.71s	_0.72s	_{p=0.405 n=6}
_{Check Time}	_{9.42s (± 0.58%)}	_{9.45s (± 0.31%)}	_~	_9.41s	_9.50s	_{p=0.221 n=6}
_{Emit Time}	_{2.74s (± 0.30%)}	_{2.75s (± 0.51%)}	_~	_2.73s	_2.77s	_{p=0.548 n=6}
_{Total Time}	_{14.17s (± 0.40%)}	_{14.21s (± 0.21%)}	_~	_14.19s	_14.27s	_{p=0.199 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,051	_407,050	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,218,359k (± 0.00%)}	_{1,218,328k (± 0.00%)}	_~	_1,218,282k	_1,218,370k	_{p=0.128 n=6}
_{Parse Time}	_{6.64s (± 0.54%)}	_{6.67s (± 0.51%)}	_~	_6.61s	_6.70s	_{p=0.376 n=6}
_{Bind Time}	_{1.86s (± 0.53%)}	_{1.86s (± 0.40%)}	_~	_1.85s	_1.87s	_{p=0.554 n=6}
_{Check Time}	_{30.62s (± 0.27%)}	_{30.59s (± 0.37%)}	_~	_30.49s	_30.77s	_{p=0.521 n=6}
_{Emit Time}	_{13.53s (± 0.62%)}	_{13.52s (± 0.49%)}	_~	_13.40s	_13.60s	_{p=0.520 n=6}
_{Total Time}	_{52.65s (± 0.23%)}	_{52.63s (± 0.15%)}	_~	_52.55s	_52.76s	_{p=0.810 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,134,511	_2,134,511	_~	_~	_~	_{p=1.000 n=6}
_Types	_927,068	_927,067	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,116,050k (± 0.00%)}	_{2,116,104k (± 0.01%)}	_~	_2,115,946k	_2,116,217k	_{p=0.378 n=6}
_{Parse Time}	_{6.60s (± 0.26%)}	_{6.62s (± 0.51%)}	_~	_6.57s	_6.66s	_{p=0.226 n=6}
_{Bind Time}	_{2.33s (± 1.38%)}	_{2.34s (± 1.35%)}	_~	_2.31s	_2.38s	_{p=0.405 n=6}
_{Check Time}	_{70.35s (± 0.91%)}	_{70.26s (± 1.81%)}	_~	_68.57s	_71.43s	_{p=0.378 n=6}
_{Emit Time}	_{0.13s (± 3.87%)}	_{0.14s (± 3.77%)}	_~	_0.13s	_0.14s	_{p=0.311 n=6}
_{Total Time}	_{79.41s (± 0.76%)}	_{79.36s (± 1.57%)}	_~	_77.69s	_80.54s	_{p=0.378 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,804	_1,230,806	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,202	_261,203	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,346,482k (± 0.03%)}	_{2,346,981k (± 0.05%)}	_~	_2,344,794k	_2,348,282k	_{p=0.471 n=6}
_{Parse Time}	_{5.93s (± 0.36%)}	_{5.93s (± 0.90%)}	_~	_5.89s	_6.03s	_{p=0.630 n=6}
_{Bind Time}	_{2.29s (± 0.99%)}	_{2.26s (± 0.97%)}	_~	_2.24s	_2.30s	_{p=0.053 n=6}
_{Check Time}	_{39.73s (± 0.21%)}	_{39.76s (± 0.24%)}	_~	_39.60s	_39.85s	_{p=0.471 n=6}
_{Emit Time}	_{3.15s (± 2.63%)}	_{3.09s (± 1.87%)}	_~	_3.02s	_3.19s	_{p=0.170 n=6}
_{Total Time}	_{51.11s (± 0.22%)}	_{51.06s (± 0.15%)}	_~	_50.96s	_51.13s	_{p=0.093 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,804	_1,230,806	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,202	_261,203	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,421,276k (± 0.04%)}	_{2,421,321k (± 0.05%)}	_~	_2,420,031k	_2,422,829k	_{p=1.000 n=6}
_{Parse Time}	_{5.13s (± 1.25%)}	_{5.15s (± 1.07%)}	_~	_5.08s	_5.22s	_{p=0.521 n=6}
_{Bind Time}	_{1.69s (± 0.97%)}	_{1.69s (± 0.81%)}	_~	_1.67s	_1.70s	_{p=1.000 n=6}
_{Check Time}	_{34.18s (± 0.30%)}	_{34.04s (± 0.36%)}	_~	_33.87s	_34.17s	_{p=0.128 n=6}
_{Emit Time}	_{2.73s (± 2.71%)}	_{2.72s (± 2.45%)}	_~	_2.63s	_2.80s	_{p=0.748 n=6}
_{Total Time}	_{43.77s (± 0.14%)}	_{43.63s (± 0.27%)}	_~	_43.45s	_43.81s	_{p=0.066 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,574	_258,576	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,825	_104,825	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{428,227k (± 0.02%)}	_{428,204k (± 0.01%)}	_~	_428,173k	_428,249k	_{p=0.936 n=6}
_{Parse Time}	_{3.31s (± 0.59%)}	_{3.31s (± 0.62%)}	_~	_3.29s	_3.34s	_{p=1.000 n=6}
_{Bind Time}	_{1.31s (± 0.75%)}	_{1.31s (± 1.63%)}	_~	_1.29s	_1.34s	_{p=1.000 n=6}
_{Check Time}	_{17.70s (± 0.42%)}	_{17.76s (± 0.57%)}	_~	_17.65s	_17.93s	_{p=0.293 n=6}
_{Emit Time}	_{1.38s (± 1.41%)}	_{1.38s (± 1.76%)}	_~	_1.34s	_1.41s	_{p=0.935 n=6}
_{Total Time}	_{23.70s (± 0.29%)}	_{23.76s (± 0.45%)}	_~	_23.62s	_23.92s	_{p=0.261 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,528k (± 0.03%)}	_{369,453k (± 0.02%)}	_~	_369,344k	_369,614k	_{p=0.378 n=6}
_{Parse Time}	_{2.77s (± 0.90%)}	_{2.78s (± 0.98%)}	_~	_2.75s	_2.82s	_{p=0.289 n=6}
_{Bind Time}	_{1.59s (± 0.97%)}	_{1.59s (± 1.03%)}	_~	_1.56s	_1.61s	_{p=1.000 n=6}
_{Check Time}	_{15.44s (± 0.34%)}	_{15.46s (± 0.28%)}	_~	_15.40s	_15.52s	_{p=0.520 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.80s (± 0.34%)}	_{19.82s (± 0.22%)}	_~	_19.77s	_19.88s	_{p=0.630 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁₃₉	₁₃₉	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,854,562	_2,854,562	_~	_~	_~	_{p=1.000 n=6}
_Types	_976,042	_976,044	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,045,625k (± 0.00%)}	_{3,045,671k (± 0.00%)}	_{+46k (+ 0.00%)}	_3,045,650k	_3,045,720k	_{p=0.045 n=6}
_{Parse Time}	_{13.52s (± 0.18%)}	_{13.54s (± 0.51%)}	_~	_13.47s	_13.65s	_{p=0.873 n=6}
_{Bind Time}	_{4.24s (± 0.39%)}	_{4.25s (± 0.42%)}	_~	_4.23s	_4.27s	_{p=0.367 n=6}
_{Check Time}	_{74.11s (± 0.50%)}	_{75.38s (± 2.95%)}	_~	_73.57s	_78.37s	_{p=0.689 n=6}
_{Emit Time}	_{24.04s (± 0.16%)}	_{22.79s (± 8.81%)}	_~	_20.15s	_24.27s	_{p=0.470 n=6}
_{Total Time}	_{115.91s (± 0.30%)}	_{115.96s (± 0.33%)}	_~	_115.45s	_116.31s	_{p=0.936 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,534k (± 0.01%)}	_{411,588k (± 0.02%)}	_~	_411,491k	_411,672k	_{p=0.128 n=6}
_{Parse Time}	_{3.82s (± 0.87%)}	_{3.82s (± 0.81%)}	_~	_3.79s	_3.86s	_{p=0.936 n=6}
_{Bind Time}	_{1.69s (± 0.31%)}	_{1.69s (± 0.53%)}	_~	_1.68s	_1.70s	_{p=0.541 n=6}
_{Check Time}	_{16.70s (± 0.31%)}	_{16.73s (± 0.36%)}	_~	_16.62s	_16.79s	_{p=0.470 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.20s (± 0.24%)}	_{22.24s (± 0.32%)}	_~	_22.12s	_22.31s	_{p=0.336 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,644k (± 0.06%)}	_{462,945k (± 0.05%)}	_~	_462,513k	_463,197k	_{p=0.128 n=6}
_{Parse Time}	_{3.92s (± 0.38%)}	_{3.93s (± 0.34%)}	_~	_3.91s	_3.95s	_{p=0.310 n=6}
_{Bind Time}	_{1.46s (± 1.35%)}	_{1.44s (± 1.34%)}	_~	_1.42s	_1.47s	_{p=0.195 n=6}
_{Check Time}	_{22.14s (± 0.32%)}	_{22.22s (± 0.18%)}	_~	_22.17s	_22.29s	_{p=0.107 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.52s (± 0.30%)}	_{27.59s (± 0.17%)}	_~	_27.54s	_27.68s	_{p=0.106 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-06-22T14:04:10Z

@ahejlsberg Here are the results of running the top 400 repos with tsc comparing main and refs/pull/58974/merge:

Everything looks good!

ahejlsberg · 2024-06-23T08:45:13Z

Tests and performance are all clean. This should be ready to merge.

ahejlsberg added 2 commits June 22, 2024 14:05

Handle partially overlapping discriminants

2e68b76

Accept new baselines

c994e9f

typescript-bot assigned ahejlsberg Jun 22, 2024

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jun 22, 2024

Add tests

559d8e7

ahejlsberg requested a review from RyanCavanaugh June 23, 2024 07:45

jakebailey approved these changes Jun 24, 2024

View reviewed changes

RyanCavanaugh approved these changes Jun 24, 2024

View reviewed changes

ahejlsberg merged commit 6c01f6c into main Jun 25, 2024
28 checks passed

ahejlsberg deleted the fix58603-2 branch June 25, 2024 05:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow partial matches in discrimination logic #58974

Allow partial matches in discrimination logic #58974

ahejlsberg commented Jun 22, 2024

ahejlsberg commented Jun 22, 2024

typescript-bot commented Jun 22, 2024 •

edited

Loading

typescript-bot commented Jun 22, 2024

typescript-bot commented Jun 22, 2024

typescript-bot commented Jun 22, 2024

tsc

typescript-bot commented Jun 22, 2024

ahejlsberg commented Jun 23, 2024

Allow partial matches in discrimination logic #58974

Allow partial matches in discrimination logic #58974

Conversation

ahejlsberg commented Jun 22, 2024

ahejlsberg commented Jun 22, 2024

typescript-bot commented Jun 22, 2024 • edited Loading

typescript-bot commented Jun 22, 2024

typescript-bot commented Jun 22, 2024

typescript-bot commented Jun 22, 2024

tsc

typescript-bot commented Jun 22, 2024

ahejlsberg commented Jun 23, 2024

typescript-bot commented Jun 22, 2024 •

edited

Loading