Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

ENH: Move hi-ml and fastMRI to PyPI packages #752

Merged
merged 9 commits into from
Jun 23, 2022

Conversation

peterhessey
Copy link
Contributor

@peterhessey peterhessey commented Jun 22, 2022

Closes #695

Previously both the hi-ml and fastmri packages were being created as submodules, which makes very little sense in a production context.

This PR removes these submodules and instead creates an environment where both of these are instead imported as PyPI packages. In order to get the latest version of fastmri (0.2.0) python version >3.8 is required, and as such this PR also includes an upgrade of python to 3.8.3.

@peterhessey peterhessey marked this pull request as draft June 22, 2022 10:30
@peterhessey peterhessey force-pushed the phessey/move-himl-FastMRI-to-PyPI branch from c8081bd to c901822 Compare June 22, 2022 13:18
@fepegar fepegar self-requested a review June 22, 2022 15:44
@peterhessey peterhessey force-pushed the phessey/move-himl-FastMRI-to-PyPI branch from 22686aa to 07db566 Compare June 22, 2022 15:49
@peterhessey peterhessey force-pushed the phessey/move-himl-FastMRI-to-PyPI branch from 07db566 to 8ded451 Compare June 22, 2022 15:56
@peterhessey peterhessey requested a review from ant0nsc June 22, 2022 16:02
@peterhessey peterhessey marked this pull request as ready for review June 22, 2022 16:06
Copy link
Contributor

@ant0nsc ant0nsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also the code at various places that messes with sys.path to include the submodules, this can be removed too.

@peterhessey peterhessey force-pushed the phessey/move-himl-FastMRI-to-PyPI branch from 8ded451 to 32e5649 Compare June 22, 2022 16:13
@peterhessey peterhessey force-pushed the phessey/move-himl-FastMRI-to-PyPI branch from c7a6f1a to 26274bf Compare June 23, 2022 08:17
@peterhessey peterhessey merged commit 38f8303 into main Jun 23, 2022
@peterhessey peterhessey deleted the phessey/move-himl-FastMRI-to-PyPI branch June 23, 2022 08:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move FastMRI and hi-ml from submodules to PyPI packages
3 participants