Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

ENH: Remove cucim + change lock script line endings #750

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

peterhessey
Copy link
Contributor

@peterhessey peterhessey commented Jun 21, 2022

Closes #749

Removed cucim and locked secondary dependencies accordingly. Also changes lock script line endings, they seem to have been set to CRLF at some point, switched back to LF now so that it can be run from a bash shell.

@peterhessey peterhessey requested a review from fepegar June 21, 2022 16:19
Copy link
Contributor

@fepegar fepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot more going on than specified in the title. Why are all those dependencies being upgraded?

@peterhessey
Copy link
Contributor Author

There's a lot more going on than specified in the title. Why are all those dependencies being upgraded?

@fepegar I ran the locking script after removing the cucim package and as such it's upgraded a number of other secondary dependencies at the same time, as pip uses the latest compatible versions of each package. It looks a number of the secondary dependencies have had updates since the last time the environment file was locked.

Copy link
Contributor

@fepegar fepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterhessey peterhessey merged commit b42043f into main Jun 21, 2022
@peterhessey peterhessey deleted the phessey/remove-cucim branch June 21, 2022 21:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment definition contains cucim, but we don't need/use it
3 participants