This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Print out name of log level, not only the number #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javier-alvarez
approved these changes
Mar 2, 2022
javier-alvarez
approved these changes
Mar 3, 2022
ant0nsc
approved these changes
Mar 7, 2022
|
@fepegar , regarding print versus logging.info: Could do that as well, yes, my initial thought here was to print it irrespective of the current logging level. Any output later in the code is done via logging.info/warning. |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logs currently show "
Setting logging level to 20". This is not very nice.I have added a small function that prints out "
Setting logging level to 20 (INFO)" instead.This is printed out using
print. Should we uselogging.infoinstead?