Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Print out name of log level, not only the number #678

Merged
merged 5 commits into from
Mar 7, 2022

Conversation

fepegar
Copy link
Contributor

@fepegar fepegar commented Mar 1, 2022

The logs currently show "Setting logging level to 20". This is not very nice.

I have added a small function that prints out "Setting logging level to 20 (INFO)" instead.

This is printed out using print. Should we use logging.info instead?

Copy link
Contributor

@javier-alvarez javier-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the description of the PR. Remove checklist.

@ant0nsc
Copy link
Contributor

ant0nsc commented Mar 7, 2022

@fepegar , regarding print versus logging.info: Could do that as well, yes, my initial thought here was to print it irrespective of the current logging level. Any output later in the code is done via logging.info/warning.

@fepegar fepegar enabled auto-merge (squash) March 7, 2022 09:43
@fepegar fepegar merged commit 6b62d8c into microsoft:main Mar 7, 2022
@fepegar fepegar deleted the show-log-level-string branch March 7, 2022 10:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants