This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Minor changes to CovidModel config parameters and updated report #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dccastro
suggested changes
Aug 25, 2021
| LoggingColumns.ModelOutput.value: [np.argmax(predictions)], | ||
| LoggingColumns.Label.value: [np.argmax(labels)]}) | ||
| pred_cvx03vs12 = predictions[1] + predictions[2] | ||
| label_cvx03vs12 = 1 if labels[1] or labels[2] else 0 |
There was a problem hiding this comment.
minor: for this kind of statement I believe the intent would be clearer with int(labels[1] or labels[2])
There was a problem hiding this comment.
sorry, I meant label_cvx03vs12 = int(labels[1] or labels[2]). on second thought it may be better to revert to how it was initially, for consistency with the rest 🙂
dumbledad
approved these changes
Aug 25, 2021
dccastro
approved these changes
Aug 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CovidModelconfigpretraining_dataset_idtoNIH_COVID_BYOLto specify the training datasetCovidModel