Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Update PL to 1.3.8 #531

Merged
merged 27 commits into from
Jul 13, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
back to how it was
  • Loading branch information
melanibe committed Jul 6, 2021
commit 909853444fd3e49b0f9875250391f04f89ce5811
6 changes: 3 additions & 3 deletions InnerEye/ML/SSL/lightning_modules/ssl_online_evaluator.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def on_pretrain_routine_start(self, trainer: pl.Trainer, pl_module: pl.Lightning
p=self.drop_p,
n_hidden=self.hidden_dim).to(pl_module.device)
assert isinstance(pl_module.non_linear_evaluator, torch.nn.Module)
self.online_optimizer = torch.optim.Adam(pl_module.non_linear_evaluator.parameters(),
self.optimizer = torch.optim.Adam(pl_module.non_linear_evaluator.parameters(),
lr=self.learning_rate,
weight_decay=self.weight_decay)

Expand Down Expand Up @@ -126,9 +126,9 @@ def on_train_batch_end(self, trainer, pl_module, outputs, batch, batch_idx, data
if ids_linear_head not in self.visited_ids:
self.visited_ids.add(ids_linear_head)
loss = self.shared_step(batch, pl_module, is_training=True)
self.online_optimizer.zero_grad()
self.optimizer.zero_grad()
loss.backward()
self.online_optimizer.step()
self.optimizer.step()

# log metrics
pl_module.log('ssl_online_evaluator/train/loss', loss)
Expand Down