Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Fix multi-node bug in PL 1.2.8 #437

Merged
merged 9 commits into from
Apr 16, 2021
Merged

Fix multi-node bug in PL 1.2.8 #437

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ca8ea84
Fix the bug in PL
Apr 16, 2021
f2ea55c
Add back the test
Apr 16, 2021
3374b97
Missing import
Apr 16, 2021
c37a423
CHANGELOG.md
Apr 16, 2021
93b0cee
Fix it
Apr 16, 2021
fa179a0
Only plugin if more than one gpu
Apr 16, 2021
9751d79
Only plugin if more than one gpu
Apr 16, 2021
68db907
Mypy
Apr 16, 2021
940cb1c
Mypy again
Apr 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CHANGELOG.md
  • Loading branch information
melanibe committed Apr 16, 2021
commit c37a4238a6b3a49d83b2369ce8312cf7d179a322
7 changes: 5 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,18 @@ created.
- ([#432](https://github.com/microsoft/InnerEye-DeepLearning/pull/432)) Upgraded to PyTorch-Lightning 1.2.7. Add
end-to-end test for classification cross-validation. WARNING: upgrade PL version causes hanging of multi-node
training.
- ([#437])(https://github.com/microsoft/InnerEye-DeepLearning/pull/437)) Upgrade to PyTorch-Lightning 1.2.8.

### Fixed
- ([#422](https://github.com/microsoft/InnerEye-DeepLearning/pull/422)) Documentation - clarified `setting_up_aml.md`
datastore creation instructions and fixed small typos in `hello_world_model.md`
- ([#432](https://github.com/microsoft/InnerEye-DeepLearning/pull/432)) Fixed cross-validation for classification
models. Fixed multi-gpu metrics aggregation. Add end-to-end test for classification cross-validation. Add fix to bug
in ddp setting when running multi-node with 1 gpu per node.
- ([#435](https://github.com/microsoft/InnerEye-DeepLearning/pull/435)) If parameter `model` in `AzureConfig` is not set, display an error message and terminate the run.

- ([#435](https://github.com/microsoft/InnerEye-DeepLearning/pull/435)) If parameter `model` in `AzureConfig` is not
set, display an error message and terminate the run.
- ([#437](https://github.com/microsoft/InnerEye-DeepLearning/pull/437)) Fixed multi-node DDP bug in PL v1.2.8. Re-add
end-to-end test for multi-node.
### Removed

### Deprecated
Expand Down