This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fix multi-node bug in PL 1.2.8 #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javier-alvarez
previously approved these changes
Apr 16, 2021
ozan-oktay
previously approved these changes
Apr 16, 2021
javier-alvarez
previously approved these changes
Apr 16, 2021
melanibe
dismissed stale reviews from javier-alvarez and ozan-oktay
via
940cb1c
javier-alvarez
approved these changes
Apr 16, 2021
ozan-oktay
approved these changes
Apr 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug in the DDPPlugin of PL v1.2.8. The bug was that in
_call_children_scriptswhere DDPPlugin assert thatglobal_rank == 0whereas this function should be called on every node i.e. assertlocal_rank == 0.(Tested on 1 node - 4 gpus, 2 nodes 1 gpu and 2 nodes 2 gpus)
Re-adds the end-2-end test for 2 nodes training in the build pipeline.
Closes #436