This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
ENH: Move hi-ml and fastMRI to PyPI packages #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterhessey
force-pushed
the
phessey/move-himl-FastMRI-to-PyPI
branch
from
c8081bd
to
c901822
Compare
peterhessey
force-pushed
the
phessey/move-himl-FastMRI-to-PyPI
branch
from
22686aa
to
07db566
Compare
fepegar
approved these changes
Jun 22, 2022
fepegar
reviewed
Jun 22, 2022
peterhessey
force-pushed
the
phessey/move-himl-FastMRI-to-PyPI
branch
from
07db566
to
8ded451
Compare
ant0nsc
suggested changes
Jun 22, 2022
peterhessey
force-pushed
the
phessey/move-himl-FastMRI-to-PyPI
branch
from
8ded451
to
32e5649
Compare
ant0nsc
approved these changes
Jun 22, 2022
peterhessey
force-pushed
the
phessey/move-himl-FastMRI-to-PyPI
branch
from
c7a6f1a
to
26274bf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #695
Previously both the
hi-mlandfastmripackages were being created as submodules, which makes very little sense in a production context.This PR removes these submodules and instead creates an environment where both of these are instead imported as PyPI packages. In order to get the latest version of fastmri (0.2.0) python version >3.8 is required, and as such this PR also includes an upgrade of python to 3.8.3.