Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed play icon from hostconfig #3126

Merged
merged 1 commit into from
Jul 1, 2019
Merged

removed play icon from hostconfig #3126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion source/ios/AdaptiveCards/ADCIOSVisualizer/resources/sample.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,6 @@
"spacing": 5
},
"media": {
"playButton" :"https://www.shareicon.net/download/64x64/2017/04/08/883361_media_512x512.png",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we perhaps host a play button icon on adaptivecards.io that you can reference? seems like it's worth having a custom playButton in our tests...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively can we get this image added as part of the test artifacts/resources that are referenced locally and dont require an external call over the wire?

In reply to: 299165267 [](ancestors = 299165267)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only concern would be if there's a runtime difference between pulling from a URL vs. local disk :)

In reply to: 299171295 [](ancestors = 299171295,299165267)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both approaches look good to me. i can add resource resolver to make references to a local bundle.

I think that Paul's concern is legitimate one. I think that there is a value in testing imaging loading through network as they are the most frequently used mode of transport.

I will create an issue to track this issue and for discussion.
#3127

In reply to: 299206526 [](ancestors = 299206526,299171295,299165267)

"allowInlinePlayback" : true
}
}