Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we perhaps host a play button icon on adaptivecards.io that you can reference? seems like it's worth having a custom
playButton
in our tests...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively can we get this image added as part of the test artifacts/resources that are referenced locally and dont require an external call over the wire?
In reply to: 299165267 [](ancestors = 299165267)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only concern would be if there's a runtime difference between pulling from a URL vs. local disk :)
In reply to: 299171295 [](ancestors = 299171295,299165267)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both approaches look good to me. i can add resource resolver to make references to a local bundle.
I think that Paul's concern is legitimate one. I think that there is a value in testing imaging loading through network as they are the most frequently used mode of transport.
I will create an issue to track this issue and for discussion.
#3127
In reply to: 299206526 [](ancestors = 299206526,299171295,299165267)