Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ihe): ihe gw results are incomplete for dr #2317

Merged
merged 4 commits into from
Jun 21, 2024
Merged

fix(ihe): ihe gw results are incomplete for dr #2317

merged 4 commits into from
Jun 21, 2024

Conversation

jonahkaye
Copy link
Member

@jonahkaye jonahkaye commented Jun 20, 2024 •
edited
Loading

Ticket: #1667

Dependencies

Description

  • fix IHE GW Results are incomplete for Document Retrieval - context
  • basically we were getting more results back than expecting, and the reason was that for several gateways the logic was in the lambdas to split them up into more 1 docRef requests. So then we would expect 10 results but get back 11 and then throw this warning. This PR moves that logic into the api so that the requests are fully broken up before being sent to the lambdas

Testing

  • local
    • unit tests

Release Plan

  • Merge this

@jonahkaye jonahkaye changed the title feat(ihe): fix ihe gw results are incomplete for dr fix(ihe): ihe gw results are incomplete for dr Jun 20, 2024
@jonahkaye jonahkaye mentioned this pull request Jun 20, 2024
Merged
2 tasks
@jonahkaye jonahkaye marked this pull request as ready for review June 20, 2024 20:56
@jonahkaye
feat(ihe): branch to branch
4e07c99 
Refs: #1667
Signed-off-by: Jonah Kaye <[email protected]>
@jonahkaye
feat(ihe): ? not |
09f0610 
Refs: #1667
Signed-off-by: Jonah Kaye <[email protected]>
leite08
leite08 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@leite08 leite08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@jonahkaye jonahkaye mentioned this pull request Jun 21, 2024
Merged
1 task
@jonahkaye jonahkaye changed the base branch from 1667-improve-retries-logging-ihe-v2 to develop June 21, 2024 18:02
@jonahkaye
feat(ihe): develop to branch
47b931c 
Refs: #1667
Signed-off-by: Jonah Kaye <[email protected]>
@jonahkaye jonahkaye added this pull request to the merge queue Jun 21, 2024
Merged via the queue into develop with commit 55af7e9 Jun 21, 2024
11 checks passed
@jonahkaye jonahkaye deleted the fix-dr-gateways-count branch June 21, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leite08 leite08 leite08 approved these changes

@Orta21 Orta21 Orta21 approved these changes

@Goncharo Goncharo Awaiting requested review from Goncharo Goncharo is a code owner

@RamilGaripov RamilGaripov Awaiting requested review from RamilGaripov RamilGaripov is a code owner

@thomasyopes thomasyopes Awaiting requested review from thomasyopes thomasyopes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonahkaye @leite08 @Orta21