Sub request id + improve retries logging for ihe v2 + Retries for ERR_BAD_RESPONSE on DQ #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: #1667 Signed-off-by: Jonah Kaye <[email protected]>
jonahkaye
changed the base branch from
develop
to
1667-stream-flow-epic-larger-chunks
jonahkaye
requested review from
Goncharo,
leite08,
Orta21,
RamilGaripov and
thomasyopes
as code owners
jonahkaye
changed the title
3 tasks
jonahkaye
commented
Jun 20, 2024
packages/api/src/external/carequality/document/create-outbound-document-retrieval-req.ts
Outdated
Show resolved
Hide resolved
2 tasks
Refs: #1667 Signed-off-by: Jonah Kaye <[email protected]>
Refs: #1667 Signed-off-by: Jonah Kaye <[email protected]>
Refs: #1667 Signed-off-by: Jonah Kaye <[email protected]>
jonahkaye
changed the title
Refs: #1667 Signed-off-by: Jonah Kaye <[email protected]>
Orta21
reviewed
Jun 21, 2024
| @@ -31,6 +31,7 @@ export type SamlAttributes = z.infer<typeof SamlAttributesSchema>; | |||
|
|
|||
| export const baseRequestSchema = z.object({ | |||
| id: z.string(), | |||
| subRequestId: z.string().optional(), | |||
There was a problem hiding this comment.
Will there always be a subRequestId? If not should we set as optional?
There was a problem hiding this comment.
nit: I'd use .nullish(), since those are used to validate HTTP requests and passing "null" for a prop is a common thing there.
Orta21
approved these changes
Jun 21, 2024
leite08
reviewed
Jun 21, 2024
packages/api/src/external/carequality/document/create-outbound-document-retrieval-req.ts
Outdated
Show resolved
Hide resolved
packages/core/src/external/carequality/ihe-gateway-v2/outbound/xca/send/dr-requests.ts
Outdated
Show resolved
Hide resolved
packages/core/src/external/carequality/ihe-gateway-v2/saml/saml-client.ts
Outdated
Show resolved
Hide resolved
leite08
reviewed
Jun 21, 2024
packages/core/src/external/carequality/ihe-gateway-v2/saml/saml-client.ts
Show resolved
Hide resolved
Refs: #1667 Signed-off-by: Jonah Kaye <[email protected]>
Refs: #1667 Signed-off-by: Jonah Kaye <[email protected]>
Refs: #1667 Signed-off-by: Jonah Kaye <[email protected]>
leite08
approved these changes
Jun 21, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #1667
Dependencies
Description
Testing
Release Plan