Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PATCH Retries ihev2 #2291

Merged
merged 5 commits into from
Jun 18, 2024
Merged

PATCH Retries ihev2 #2291

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2ac2825
fix(ihev2): increasing dr retries count + adding bad response retry
jonahkaye Jun 18, 2024
335b7d5
fix(ihev2): constants
jonahkaye Jun 18, 2024
3ea1c5d
fix(ihev2): dayjs duration
jonahkaye Jun 18, 2024
f5a0e85
fix(ihev2): move error to axios, chunk instead of for
jonahkaye Jun 18, 2024
71430a5
fix(ihev2): ms in location its used
jonahkaye Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(ihev2): dayjs duration 
Refs: #1667
Signed-off-by: Jonah Kaye <[email protected]>
  • Loading branch information
@jonahkaye
jonahkaye committed Jun 18, 2024
commit 3ea1c5da7b6152a4696557e845a37c98b0fdd1b0
8 changes: 7 additions & 1 deletion packages/core/src/external/carequality/ihe-gateway-v2/ihe-gateway-v2-async.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,14 @@ import { makeLambdaClient } from "../../aws/lambda";
import { Config } from "../../../util/config";
import { processAsyncError } from "../../../util/error/shared";
import { IHEGatewayV2 } from "./ihe-gateway-v2";
import dayjs from "dayjs";
import duration from "dayjs/plugin/duration";

const SLEEP_IN_BETWEEN_DOCUMENT_RETRIEVAL_REQUESTS = 1000;
dayjs.extend(duration);

const SLEEP_IN_BETWEEN_DOCUMENT_RETRIEVAL_REQUESTS = dayjs
.duration({ seconds: 1 })
.asMilliseconds();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its better to create the const as duration and convert to the unit needed on the place where we use it

const MAX_GATEWAYS_BEFORE_CHUNK = 1000;
const MAX_DOCUMENT_QUERY_REQUESTS_PER_INVOCATION = 20;
const MAX_DOCUMENT_RETRIEVAL_REQUESTS_PER_INVOCATION = 20;
Expand Down
Loading