PATCH Retries ihev2 #2291
Merged
PATCH Retries ihev2 #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahkaye
commented
Jun 18, 2024
| @@ -137,13 +137,21 @@ export async function sendSignedXmlMtom({ | |||
| }, | |||
| httpsAgent: agent, | |||
| responseType: "arraybuffer", | |||
| maxBodyLength: Infinity, | |||
| maxContentLength: Infinity, | |||
There was a problem hiding this comment.
maxContentLength size of -1 exceeded
^ we have had this error in prod 3 times
We added retries for ERR_BAD_RESPONSE, and this change was also recommended in this issue
jonahkaye
commented
Jun 18, 2024
There was a problem hiding this comment.
was missing these from previous PR
jonahkaye
commented
Jun 18, 2024
| @@ -111,6 +112,7 @@ export class IHEGatewayV2Async extends IHEGatewayV2 { | |||
| for (const chunk of requestChunks) { | |||
| const params = { patientId, cxId, requestId, drRequestsGatewayV2: chunk }; | |||
|
|
|||
| await sleep(1000); | |||
There was a problem hiding this comment.
delay between DR request attempts. This is within a single gateway.
Refs: #1667 Signed-off-by: Jonah Kaye <[email protected]>
jonahkaye
force-pushed
the
1667-fix-retries-ihev2
branch
from
e45834d
to
2ac2825
Compare
jonahkaye
requested review from
Goncharo,
leite08,
Orta21,
RamilGaripov and
thomasyopes
as code owners
Goncharo
reviewed
Jun 18, 2024
packages/core/src/external/carequality/ihe-gateway-v2/ihe-gateway-v2-async.ts
Outdated
Show resolved
Hide resolved
packages/core/src/external/carequality/ihe-gateway-v2/saml/saml-client.ts
Outdated
Show resolved
Hide resolved
Refs: #1667 Signed-off-by: Jonah Kaye <[email protected]>
leite08
reviewed
Jun 18, 2024
packages/core/src/external/carequality/ihe-gateway-v2/ihe-gateway-v2-async.ts
Outdated
Show resolved
Hide resolved
packages/core/src/external/carequality/ihe-gateway-v2/ihe-gateway-v2-async.ts
Outdated
Show resolved
Hide resolved
packages/core/src/external/carequality/ihe-gateway-v2/saml/saml-client.ts
Outdated
Show resolved
Hide resolved
Refs: #1667 Signed-off-by: Jonah Kaye <[email protected]>
Refs: #1667 Signed-off-by: Jonah Kaye <[email protected]>
leite08
reviewed
Jun 18, 2024
Comment on lines
17
to
19
| const SLEEP_IN_BETWEEN_DOCUMENT_RETRIEVAL_REQUESTS = dayjs | ||
| .duration({ seconds: 1 }) | ||
| .asMilliseconds(); |
There was a problem hiding this comment.
Its better to create the const as duration and convert to the unit needed on the place where we use it
Refs: #1667 Signed-off-by: Jonah Kaye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #1667
Description
Testing
Release Plan
master