Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Garmin BodyComposition mapping #17

Merged
merged 4 commits into from
Dec 29, 2022
Merged

Garmin BodyComposition mapping #17

merged 4 commits into from
Dec 29, 2022

Conversation

leite08
Copy link
Member

@leite08 leite08 commented Dec 27, 2022 •
edited
Loading

Ticket: https://github.com/metriport/metriport-internal/issues/118

Dependencies

Description

  • Garmin BodyComposition mapping.
  • Fix issue with sending internal userId on the webhook payload instead of cxUserId
  • Minor typo fix on docs

Release Plan

  • anytime
  • Release upstream dependency
  • Release this

@leite08 leite08 mentioned this pull request Dec 27, 2022
Merged
2 tasks
Goncharo
Goncharo approved these changes Dec 27, 2022
View reviewed changes
Copy link
Member

@Goncharo Goncharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor comments - but not blockers for merge

api/app/src/mappings/garmin/body-composition.ts Outdated Show resolved Hide resolved
api/app/src/mappings/garmin/body-composition.ts Outdated Show resolved Hide resolved
Base automatically changed from 43-webhook-retry_2 to develop December 28, 2022 10:14
@leite08 leite08 mentioned this pull request Dec 28, 2022
Merged
@leite08 leite08 merged commit 1bbbe32 into develop Dec 29, 2022
@leite08 leite08 deleted the 118-garmin-body branch December 29, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goncharo Goncharo Goncharo approved these changes

@Orta21 Orta21 Orta21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leite08 @Goncharo @Orta21