Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused properties from SettingsDTO #14

Merged
merged 6 commits into from
Dec 28, 2022
Merged

Remove unused properties from SettingsDTO #14

merged 6 commits into from
Dec 28, 2022

Conversation

leite08
Copy link
Member

@leite08 leite08 commented Dec 27, 2022 •
edited

Ticket: #43

Dependencies

Description

Remove unused `SettingsDTO`` properties that were left there for the release

Release Plan

  • Release upstream dependency
  • Release this

Goncharo
Goncharo approved these changes Dec 27, 2022
View reviewed changes
Copy link
Member

@Goncharo Goncharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Goncharo
Goncharo requested changes Dec 27, 2022
View reviewed changes
Copy link
Member

@Goncharo Goncharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, couple minor comments

docs/settings/get-settings.mdx Outdated Show resolved Hide resolved
docs/settings/get-webhook.mdx Outdated Show resolved Hide resolved
docs/settings/get-webhook.mdx Outdated Show resolved Hide resolved
@leite08 leite08 mentioned this pull request Dec 27, 2022
Merged
2 tasks
Goncharo
Goncharo approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@Goncharo Goncharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo - can be 🚢 after addressed!

docs/settings/get-settings.mdx Outdated Show resolved Hide resolved
Base automatically changed from 43-webhook-retry to develop December 28, 2022 10:13
@leite08 leite08 merged commit f5162bc into develop Dec 28, 2022
@leite08 leite08 deleted the 43-webhook-retry_2 branch December 28, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goncharo Goncharo Goncharo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leite08 @Goncharo