Skip to content
This repository has been archived by the owner on Jun 22, 2021. It is now read-only.

feat(time): Add duration and currentTime property accessors #1

Merged
merged 1 commit into from
Jun 30, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions src/js/Youtube.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,27 +56,46 @@ class Youtube extends Meister.MediaPlugin {
this.player.currentSrc = item.src;
}

get duration() {
if (!this.player) { return NaN; }

return this.player.duration;
}

get currentTime() {
if (!this.player) { return NaN; }

return this.player.currentTime;
}

set currentTime(time) {
if (!this.player) { return; }

this.player.currentTime = time;
}


_onPlayerTimeUpdate() {
this.meister.trigger('playerTimeUpdate', {
currentTime: this.meister.currentTime,
duration: this.meister.duration,
currentTime: this.player.currentTime,
duration: this.player.duration,
});
}

onRequestSeek(e) {
let targetTime;

if (!isNaN(e.relativePosition)) {
targetTime = e.relativePosition * this.meister.duration;
targetTime = e.relativePosition * this.player.duration;
} else if (!isNaN(e.timeOffset)) {
targetTime = this.meister.currentTime + e.timeOffset;
targetTime = this.player.currentTime + e.timeOffset;
}

// Check whether we are allowed to seek forward.
if (this.blockSeekForward && targetTime > this.meister.currentTime) { return; }
if (this.blockSeekForward && targetTime > this.player.currentTime) { return; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zouden we dit niet misschien via een super functie kunnen oplossen o.i.d. Want ik heb t gevoel dat we dit ooit bij een media plugin gaan vergeten (Of dat een 3rd party plugin t vergeet) dat we functionaliteit verliezen?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, though this feels like a new issue to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


if (Number.isFinite(targetTime)) {
this.meister.currentTime = targetTime;
this.player.currentTime = targetTime;
}
}
}
Expand Down