This repository has been archived by the owner on Jun 22, 2021. It is now read-only.
feat(time): Add duration and currentTime property accessors #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // Check whether we are allowed to seek forward. | ||
| if (this.blockSeekForward && targetTime > this.meister.currentTime) { return; } | ||
| if (this.blockSeekForward && targetTime > this.player.currentTime) { return; } |
There was a problem hiding this comment.
Zouden we dit niet misschien via een super functie kunnen oplossen o.i.d. Want ik heb t gevoel dat we dit ooit bij een media plugin gaan vergeten (Of dat een 3rd party plugin t vergeet) dat we functionaliteit verliezen?
There was a problem hiding this comment.
Good call, though this feels like a new issue to me.
There was a problem hiding this comment.
This allows the player to get correct time information without waiting for events to trigger. Part of meisterplayer/meisterplayer#36.
Thomasvdam
force-pushed
the
feature/time-properties
branch
from
04c0664
to
a79d6ff
Compare
|
Updated this branch and checked if everything still works. Is ready for review now @buttonfreak @FranklinWaller |
ivo-toby
approved these changes
Jun 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the player to get correct time information without waiting
for events to trigger. Part of meisterplayer/meisterplayer#36.