Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): correct loading behavior, add MedplumClient lifecycle events #4701

Merged
merged 4 commits into from
Jun 23, 2024

Conversation

ThatOneBro
Copy link
Member

Fixes #4694
Also fixes #4697

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medplum-provider ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 2:42am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
medplum-app ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2024 2:42am
medplum-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2024 2:42am
medplum-www ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2024 2:42am

Copy link

sonarcloud bot commented Jun 20, 2024

@ThatOneBro ThatOneBro marked this pull request as ready for review June 20, 2024 16:30
@ThatOneBro ThatOneBro requested a review from a team as a code owner June 20, 2024 16:30
@ThatOneBro ThatOneBro added this pull request to the merge queue Jun 22, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 22, 2024
…events (#4701)

* fix(client): make sure `isLoading()` and `loading` are actually in sync

* test(client): `refreshProfile()` sets  `isLoading() === true` again

* cleanup(client): move `eventtarget` import below comment

* test(mock): test `mockFetchOverride`
@ThatOneBro ThatOneBro removed this pull request from the merge queue due to a manual request Jun 22, 2024
@ThatOneBro ThatOneBro added this pull request to the merge queue Jun 23, 2024
Merged via the queue into main with commit 2a0c586 Jun 23, 2024
33 checks passed
@ThatOneBro ThatOneBro deleted the derrick-fix-loading-behavior branch June 23, 2024 00:36
@ThatOneBro ThatOneBro self-assigned this Jun 24, 2024
@reshmakh reshmakh added the fhir-datastore Related to the FHIR datastore, includes API and FHIR operations label Jun 27, 2024
medplumbot added a commit that referenced this pull request Jun 28, 2024
## What's Changed

* fix(client): correct loading behavior, add `MedplumClient` lifecycle events (#4701)
* Fix typo in ValueSet expand docs (#4714)
* Dependency upgrades 2024-06-24 (#4715)
* Polish charting demo (#4662)
* fix(core/search): remediate cannot read `type` of undefined in matchesStringFilter (#4720)
* Add ResourceTimeline 'getMenu' prop (#4717)
* Fixed athena 'create table' section (#4721)
* More SQL-on-FHIR tests (#4702)
* Fix recursive filter application in ValueSet expand (#4722)
* Guide on Migrating to Medplum (#4713)
* Adding new file (#4709)
* Optimize database reindex (#4558)
* Increase db conn pool size (#4735)
* AWS Textract demo (#4624)
* Revert "Optimize database reindex (#4558)" (#4745)
* Homepage updates (#4744)
* feat(core): add `maxRetries` opt to `MedplumRequestOptions` (#4723)
* Fixed integer64 type (#4742)

**Full Changelog**: v3.1.10...v3.1.11
github-merge-queue bot pushed a commit that referenced this pull request Jun 28, 2024
## What's Changed

* fix(client): correct loading behavior, add `MedplumClient` lifecycle events (#4701)
* Fix typo in ValueSet expand docs (#4714)
* Dependency upgrades 2024-06-24 (#4715)
* Polish charting demo (#4662)
* fix(core/search): remediate cannot read `type` of undefined in matchesStringFilter (#4720)
* Add ResourceTimeline 'getMenu' prop (#4717)
* Fixed athena 'create table' section (#4721)
* More SQL-on-FHIR tests (#4702)
* Fix recursive filter application in ValueSet expand (#4722)
* Guide on Migrating to Medplum (#4713)
* Adding new file (#4709)
* Optimize database reindex (#4558)
* Increase db conn pool size (#4735)
* AWS Textract demo (#4624)
* Revert "Optimize database reindex (#4558)" (#4745)
* Homepage updates (#4744)
* feat(core): add `maxRetries` opt to `MedplumRequestOptions` (#4723)
* Fixed integer64 type (#4742)

**Full Changelog**: v3.1.10...v3.1.11
@reshmakh reshmakh added the audit-logging Commits related to audit logging and observability label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit-logging Commits related to audit logging and observability fhir-datastore Related to the FHIR datastore, includes API and FHIR operations
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Make MedplumClient extend TypedEventTarget Fix loading tracking MedplumClient#isLoading()
3 participants