Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading tracking MedplumClient#isLoading() #4694

Open
ThatOneBro opened this issue Jun 19, 2024 · 0 comments · May be fixed by #4701
Open

Fix loading tracking MedplumClient#isLoading() #4694

ThatOneBro opened this issue Jun 19, 2024 · 0 comments · May be fixed by #4701
Assignees
@ThatOneBro
Milestone
June 30, 2024

Comments

@ThatOneBro
Copy link
Member

ThatOneBro commented Jun 19, 2024 •
edited

We partially fixed this in #4677 but it doesn't necessarily track properly in some cases.

We should also add some test cases for the matrix of:

  1. With AsyncClientStorage, with existing active login
  2. With AsyncClientStorage, NO existing active login
  3. NO AsyncClientStorage, with existing active login
  4. NO AsyncClientStorage, NO existing active login
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThatOneBro ThatOneBro

Labels
None yet
Projects
Medplum Product Roadmap
Status: 👀 In review
Milestone
June 30, 2024
Development

Successfully merging a pull request may close this issue.

fix(client): correct loading behavior, add MedplumClient lifecycle events medplum/medplum
1 participant
@ThatOneBro