chore(ci): set prettier action to run on PR to main, fix format
#2764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Kudos, SonarCloud Quality Gate passed!
|
codyebberson
approved these changes
Sep 1, 2023
codyebberson
added a commit
that referenced
this pull request
Sep 4, 2023
Agent installer performs silent upgrades (#2765) Use Turborepo cache in Github Actions (#2766) config(prettier): only run `prettier` on JS/TS-like files from CLI (#2767) Fixes #2568 - move react native example into monorepo (#2742) chore(ci): set `prettier` action to run on PR to `main`, fix format (#2764) Fix typo: "Enpoint" -> "Endpoint" (#2763) ci(prettier): add `prettier` check to Actions (#2758) Document search implementation (#2750) Bot logging fixes (#2743) Update handling of AccessPolicy write criteria and add docs (#2720) Allow search on name and address using stop word (#2749) fix(ValueSet-expand): delete null `display` fields before resp (#2746) Agent localhost testing documentation and examples (#2741) Add repeatable items and groups to Questionnaire (#2690)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 5, 2023
Agent installer performs silent upgrades (#2765) Use Turborepo cache in Github Actions (#2766) config(prettier): only run `prettier` on JS/TS-like files from CLI (#2767) Fixes #2568 - move react native example into monorepo (#2742) chore(ci): set `prettier` action to run on PR to `main`, fix format (#2764) Fix typo: "Enpoint" -> "Endpoint" (#2763) ci(prettier): add `prettier` check to Actions (#2758) Document search implementation (#2750) Bot logging fixes (#2743) Update handling of AccessPolicy write criteria and add docs (#2720) Allow search on name and address using stop word (#2749) fix(ValueSet-expand): delete null `display` fields before resp (#2746) Agent localhost testing documentation and examples (#2741) Add repeatable items and groups to Questionnaire (#2690)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Follow-up to #2758.
We have tested that the
prettierworkflow works and prevents merging code with incorrect formatting.Trying to commit unformatted code:
Fixing the mentioned errors after running
npm run prettier:What this PR does
prettierworkflow run on any PR to themainbranchprettierin CI against TS/JS-like files, but we should also lint any TypeScript in Markdown files as well to fit with our house style guide, and ournpm run prettierscript already runs against.so we might as well fix these so people don't get a bunch of files to commit if they follow the instructions given in the comment whenprettierfails.Why not autofix?
It's an anti-pattern- we should encourage devs to be running
prettierthemselves so they get in the habit of writing more conformant code and also modifying commits in CI is bad.