ci(prettier): add prettier check to Actions
#2758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Kudos, SonarCloud Quality Gate passed!
|
codyebberson
approved these changes
Sep 1, 2023
This was referenced Sep 1, 2023
codyebberson
added a commit
that referenced
this pull request
Sep 4, 2023
Agent installer performs silent upgrades (#2765) Use Turborepo cache in Github Actions (#2766) config(prettier): only run `prettier` on JS/TS-like files from CLI (#2767) Fixes #2568 - move react native example into monorepo (#2742) chore(ci): set `prettier` action to run on PR to `main`, fix format (#2764) Fix typo: "Enpoint" -> "Endpoint" (#2763) ci(prettier): add `prettier` check to Actions (#2758) Document search implementation (#2750) Bot logging fixes (#2743) Update handling of AccessPolicy write criteria and add docs (#2720) Allow search on name and address using stop word (#2749) fix(ValueSet-expand): delete null `display` fields before resp (#2746) Agent localhost testing documentation and examples (#2741) Add repeatable items and groups to Questionnaire (#2690)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 5, 2023
Agent installer performs silent upgrades (#2765) Use Turborepo cache in Github Actions (#2766) config(prettier): only run `prettier` on JS/TS-like files from CLI (#2767) Fixes #2568 - move react native example into monorepo (#2742) chore(ci): set `prettier` action to run on PR to `main`, fix format (#2764) Fix typo: "Enpoint" -> "Endpoint" (#2763) ci(prettier): add `prettier` check to Actions (#2758) Document search implementation (#2750) Bot logging fixes (#2743) Update handling of AccessPolicy write criteria and add docs (#2720) Allow search on name and address using stop word (#2749) fix(ValueSet-expand): delete null `display` fields before resp (#2746) Agent localhost testing documentation and examples (#2741) Add repeatable items and groups to Questionnaire (#2690)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Currently
prettierruns as part ofESLinton the codebase but that is kind of slow and definitely slows feedback in your editor while coding and running ESLint in your editor simultaneously. We should also encourage devs to useprettierin their editor to auto-format and catch formatting issues before committing.One way we can still catch
prettiererrors without running it inESLintis to have an action that runs against PRs and catches any newprettiererrors introduced in the new PR and report them via a comment. The comment will also mention how to fix it and even how to set up auto-formatting for newcomers or people who don't already haveprettiersetup in their editor.What this PR does
prettier-fmtGithub Action workflow and adapts it for Medplum's setupprettierformatting issues throughout the codebase so that we can start from a clean slateNext Steps
This synergizes with the changes in #2748 to remove
prettierfrom theeslintconfig well and when that PR is merged we should see a slight decrease in time toESLintfeedback.There also may be some debugging required to make sure this action is working. GitHub Action workflows are notoriously hard to debug so
derrick/test-actionshas been indicated in the new workflow as a branch to trigger this workflow on PR. The workflow can then be ensured working before we add it to PRs onmainif we choose to go this route.