fix(admin/client): use :projectId param to create client as superadmin
#2722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
rahul1
reviewed
Aug 25, 2023
ThatOneBro
commented
Aug 25, 2023
codyebberson
approved these changes
Aug 25, 2023
| const client = await createClient(res.locals.repo as Repository, { | ||
| let project: Project; | ||
| const { project: localsProject, repo } = res.locals as { project: Project; repo: Repository }; | ||
| if (localsProject.superAdmin) { |
| @@ -1,9 +1,14 @@ | |||
| import { randomUUID } from 'crypto'; | |||
| import express from 'express'; | |||
| import request from 'supertest'; | |||
| import { getReferenceString, resolveId } from '@medplum/core'; | |||
|
|
|||
There was a problem hiding this comment.
Remove blank lines & "Organize imports"
There was a problem hiding this comment.
Sweet, yeah I was wondering if you all had a style preference for imports.
I think there's a way to do auto-organize imports on save right? Or maybe thats if you use eslint as your formatter. Another way could be adding a lint rule, just to keep this consistent
There was a problem hiding this comment.
Yeah... this is a gap in our ESLint config right now. Currently we're just using the VS Code default behavior. It would be nice to enforce with ESLint/Prettier.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ThatOneBro
force-pushed
the
derrick-fix-ignored-project-id
branch
from
1f6491a
to
a700497
Compare
|
Kudos, SonarCloud Quality Gate passed! |
codyebberson
added a commit
that referenced
this pull request
Aug 27, 2023
Capturing vital signs documentation (#2651) Draft agent documentation (#2721) Fixes #2727 - add signingKeyId to param store (#2728) Organizing communications docs (#2579) feat(Storybook): enable viewing story source code (#2723) fix(admin/client): use `:projectId` param to create client as superadmin (#2722) feat(QuestionnaireForm): add support for `exists`, `!=`, etc. operators (#2714) read clientSecret from options (#2712) Enable graphql __type (#2700) add loading feedback (#2713) fix(): fix blame page (#2711) Array search via subqueries, minor refactor (#2701) Patient Deduplication Reference Implementation (#2674) Add FHIRPath criteria for write operations to AccessPolicy (#2684) Fixes #2675 - added Medplum resource types to navbar (#2698) Dependency upgrades (#2697) Updating solutions to include reference to EMPI use cases (#2695) add: app version to <meta> tag in app (#2692) Fixed cli test on windows (#2696) Adding blog content (#2686) Allow Target Type input for references (#2685) Change extension url for Questionnaire Page (#2687) Add validation benchmarks (#2420) Add Category input to ReferenceRangeEditor component (#2676) 'Add Page' to Questionnaire (#2667) fix(docs): correct client credentials flow python example (#2682) Document Lab Service Menu (#2629) Add ReCAPTCHA site key to default app config (#2681) Updating documentation for b10 (#2677) Clarify user admin (#2671) Clarify that patients can be part of more than one gropu (#2669) Fixes #1418 - bot layer docs (#2656) Keep super admin notifications open until user closes (#2666) JWT Assertion login for CLI (#2590) Add default base URL to agent installer (#2665) Use repo.searchOne where possible (#2661) Fixes #1236 - login UX when user does not have membership (#2660) Extract HL7 headers from bot input for AWS Athena (#2659) Clean up temp binary storage for unit tests (#2658) Dependency upgrades (#2655) Blog post on system strings (#2646) Allow bots to return Hl7Message instances (#2653) Agent installer (#2652) Deploy bot layer on new release version (#2654) Enable profile validation (#2649) Fixed JSON escaping of HL7 strings from lambda bots (#2650) Handle slicing edge cases for profile validation (#2620) Document system only search (#2648) Medplum Agent data definitions (#2640) Improve handling of primitive extension properties (#2641) Fixes #2618 - initial field selection in filters dialog (#2645) Document GraphQL list filtering with FHIRPath (#2643) JWT Bearer Login for CLI (#2587) fix(docs): fix typo in `family-relationships.mdx` (#2644)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 27, 2023
Capturing vital signs documentation (#2651) Draft agent documentation (#2721) Fixes #2727 - add signingKeyId to param store (#2728) Organizing communications docs (#2579) feat(Storybook): enable viewing story source code (#2723) fix(admin/client): use `:projectId` param to create client as superadmin (#2722) feat(QuestionnaireForm): add support for `exists`, `!=`, etc. operators (#2714) read clientSecret from options (#2712) Enable graphql __type (#2700) add loading feedback (#2713) fix(): fix blame page (#2711) Array search via subqueries, minor refactor (#2701) Patient Deduplication Reference Implementation (#2674) Add FHIRPath criteria for write operations to AccessPolicy (#2684) Fixes #2675 - added Medplum resource types to navbar (#2698) Dependency upgrades (#2697) Updating solutions to include reference to EMPI use cases (#2695) add: app version to <meta> tag in app (#2692) Fixed cli test on windows (#2696) Adding blog content (#2686) Allow Target Type input for references (#2685) Change extension url for Questionnaire Page (#2687) Add validation benchmarks (#2420) Add Category input to ReferenceRangeEditor component (#2676) 'Add Page' to Questionnaire (#2667) fix(docs): correct client credentials flow python example (#2682) Document Lab Service Menu (#2629) Add ReCAPTCHA site key to default app config (#2681) Updating documentation for b10 (#2677) Clarify user admin (#2671) Clarify that patients can be part of more than one gropu (#2669) Fixes #1418 - bot layer docs (#2656) Keep super admin notifications open until user closes (#2666) JWT Assertion login for CLI (#2590) Add default base URL to agent installer (#2665) Use repo.searchOne where possible (#2661) Fixes #1236 - login UX when user does not have membership (#2660) Extract HL7 headers from bot input for AWS Athena (#2659) Clean up temp binary storage for unit tests (#2658) Dependency upgrades (#2655) Blog post on system strings (#2646) Allow bots to return Hl7Message instances (#2653) Agent installer (#2652) Deploy bot layer on new release version (#2654) Enable profile validation (#2649) Fixed JSON escaping of HL7 strings from lambda bots (#2650) Handle slicing edge cases for profile validation (#2620) Document system only search (#2648) Medplum Agent data definitions (#2640) Improve handling of primitive extension properties (#2641) Fixes #2618 - initial field selection in filters dialog (#2645) Document GraphQL list filtering with FHIRPath (#2643) JWT Bearer Login for CLI (#2587) fix(docs): fix typo in `family-relationships.mdx` (#2644)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2717
Originally wanted to use
metafields onClientApplicationto check for the project ID, but may have found a bug around the meta field being clobbered by addition of versioning info on initial creation of a resource, or at least theClientApplication. (Will probably open an issue about this tomorrow once I have more info)