Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClientApplication endpoint ignores :projectId as SuperAdmin #2717

Closed
rahul1 opened this issue Aug 24, 2023 · 0 comments · Fixed by #2722
Closed

ClientApplication endpoint ignores :projectId as SuperAdmin #2717

rahul1 opened this issue Aug 24, 2023 · 0 comments · Fixed by #2722
Assignees
@rahul1 @ThatOneBro
Labels
auth Authentication and authorization features and fixes bug Something isn't working
Milestone
August 31, 2023

Comments

@rahul1
Copy link
Member

rahul1 commented Aug 24, 2023

The endpoint /admin/projects/:projectId/client currently ignores the :projectId param. This prevents users from inviting

We should replicate the functionality In the /invite endpoint:

  • Most of the time, we read the project id from res.locals
  • But if the user is Superadmin, wer read the project id from the URL params

medplum/packages/server/src/admin/invite.ts

Lines 44 to 50 in c7291e6

const inviteRequest = { ...req.body } as ServerInviteRequest;
const { projectId } = req.params;
if (res.locals.project.superAdmin) {
inviteRequest.project = await systemRepo.readResource('Project', projectId as string);
} else {
inviteRequest.project = res.locals.project;
}

@rahul1 rahul1 added bug Something isn't working auth Authentication and authorization features and fixes labels Aug 24, 2023
@rahul1 rahul1 self-assigned this Aug 24, 2023
This was referenced Aug 24, 2023
Merged
Merged
@ThatOneBro ThatOneBro self-assigned this Aug 25, 2023
@ThatOneBro ThatOneBro added this to the August 31, 2023 milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahul1 rahul1

@ThatOneBro ThatOneBro

Labels
auth Authentication and authorization features and fixes bug Something isn't working
Projects
Medplum Product Roadmap
Archived in project
Milestone
August 31, 2023
Development

Successfully merging a pull request may close this issue.

fix(admin/client): use :projectId param to create client as superadmin medplum/medplum
2 participants
@rahul1 @ThatOneBro