-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(#8938): Nepali translations up to Line 200 #8979
Conversation
@@ -44,24 +51,24 @@ Confirm = पुष्टी गर्नुहोस् | |||
Confirm\ Password = पासवर्ड पृष्टि गर्नु |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be पुष्टी instead of पृष्टि ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I refer to this dictionary, which is very similar to the official one Nepali Brihat Sambdakosh, it says पुष्टि
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@binokaryg changing पृष्टि to पुष्टि?
Default\ country\ code = पुर्बनिर्धारित राष्ट्र कोड | ||
Default\ country\ code\ help = यो कोड देश कोड बिना सिस्टम मा प्रविष्टि सबै फोन नम्बर ठहराया गरिनेछ । | ||
Default\ country\ code = पुर्वनिर्धारित राष्ट्र कोड | ||
Default\ country\ code\ help = देशको कोड बिना राखिएका सबै नम्बर हरुमा यो कोड थपिने छ। |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
नम्बर हरुमा to नम्बरहरुमा? extra space
Discard\ changes\ to\ current\ language = तपाईं जारी र हालको भाषा गरे परिवर्तनहरू रद्द गर्न चाहनुहुन्छ ? | ||
Display = | ||
Disable = डिसेबल गर्नुहोस् | ||
Discard\ changes\ to\ current\ language = यो भाषामा गरेका परिवर्तन हरु सेभ नगरिकन अगाडी बढ्न चाहनु हुन्छ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
परिवर्तन हरु to परिवर्तनहरु? extra space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be हरू everywhere, not हरु. (रू vs रु)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't actually pluralize as frequently in Nepali as we pluralize nouns in English.
Number\ of\ contact\ types = {{number}} सम्पर्क प्रकार(हरु) | ||
Number\ of\ facilities = {{number}} संस्था(हरु) | ||
Number\ of\ form\ types = {{number}} प्रकारको फारम(हरु) | ||
Number\ of\ visits = {{number}}+ पटक भेटको |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure भेटको or भेटेको?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for asking me to review. I made few comments.
Discard\ changes\ to\ current\ language = तपाईं जारी र हालको भाषा गरे परिवर्तनहरू रद्द गर्न चाहनुहुन्छ ? | ||
Display = | ||
Disable = डिसेबल गर्नुहोस् | ||
Discard\ changes\ to\ current\ language = यो भाषामा गरेका परिवर्तन हरु सेभ नगरिकन अगाडी बढ्न चाहनु हुन्छ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't actually pluralize as frequently in Nepali as we pluralize nouns in English.
Co-authored-by: Binod Adhikary <[email protected]>
Many missing translations are already there in one of our configs. cht-core/api/resources/translations/messages-ne.properties Lines 290 to 303 in 6ae98c5
|
@@ -112,9 +117,8 @@ Forms = फाराम | |||
From = पठाउने | |||
Full\ Name = पुरा नाम | |||
Gateway\ number = मोडेमको नम्बर | |||
Gateway\ number\ help = यहाँ मोडेममा राखिएको सिमको फोन नम्बर राख्नुहोला। यहि नम्बरमा रिपोर्ट तथा सन्देश पठाउनु पर्नेछ तथा यहि नम्बरबाट सन्देशहरु पठाइनेछन्। | |||
Gateway\ number\ help = यहाँ मोडेममा राखिएको सिमको फोन नम्बर राख्नुहोला। यहि नम्बरमा रिपोर्ट तथा सन्देश पठाउनु पर्नेछ तथा यहि नम्बरबाट सन्देशहरू पठाइनेछन्। |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since other places have संदेश instead of सन्देश, shall we change this too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@1yuv this is the only comment I have. thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@1yuv I don't think this should be a blocker and is only related to consistency of word. So, approving the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nsitaula , I totally missed this comment, thanks for pointing. I checked that सन्देश
is accurate and that's in the nepali dictionary as well, so I've changed all refrences (up to 200Lines) to सन्देश.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding/correcting the translations. Let's continue improving.
Description
#8938
Code review checklist
Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.