Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(#8938): Nepali translations up to Line 200 #8979

Merged
merged 8 commits into from
Apr 19, 2024
Merged

Conversation

1yuv
Copy link
Member

@1yuv 1yuv commented Mar 29, 2024

Description

#8938

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@1yuv 1yuv requested review from binokaryg and nsitaula March 29, 2024 17:15
@@ -44,24 +51,24 @@ Confirm = पुष्टी गर्नुहोस्
Confirm\ Password = पासवर्ड पृष्टि गर्नु
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be पुष्टी instead of पृष्टि ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refer to this dictionary, which is very similar to the official one Nepali Brihat Sambdakosh, it says पुष्टि.

Copy link

@nsitaula nsitaula Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@binokaryg changing पृष्टि to पुष्टि?

Default\ country\ code = पुर्बनिर्धारित राष्ट्र कोड
Default\ country\ code\ help = यो कोड देश कोड बिना सिस्टम मा प्रविष्टि सबै फोन नम्बर ठहराया गरिनेछ ।
Default\ country\ code = पुर्वनिर्धारित राष्ट्र कोड
Default\ country\ code\ help = देशको कोड बिना राखिएका सबै नम्बर हरुमा यो कोड थपिने छ।
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

नम्बर हरुमा to नम्बरहरुमा? extra space

Discard\ changes\ to\ current\ language = तपाईं जारी र हालको भाषा गरे परिवर्तनहरू रद्द गर्न चाहनुहुन्छ ?
Display =
Disable = डिसेबल गर्नुहोस्
Discard\ changes\ to\ current\ language = यो भाषामा गरेका परिवर्तन हरु सेभ नगरिकन अगाडी बढ्न चाहनु हुन्छ?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

परिवर्तन हरु to परिवर्तनहरु? extra space

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be हरू everywhere, not हरु. (रू vs रु)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't actually pluralize as frequently in Nepali as we pluralize nouns in English.

Number\ of\ contact\ types = {{number}} सम्पर्क प्रकार(हरु)
Number\ of\ facilities = {{number}} संस्था(हरु)
Number\ of\ form\ types = {{number}} प्रकारको फारम(हरु)
Number\ of\ visits = {{number}}+ पटक भेटको
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure भेटको or भेटेको?

Copy link

@nsitaula nsitaula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for asking me to review. I made few comments.

api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
Discard\ changes\ to\ current\ language = तपाईं जारी र हालको भाषा गरे परिवर्तनहरू रद्द गर्न चाहनुहुन्छ ?
Display =
Disable = डिसेबल गर्नुहोस्
Discard\ changes\ to\ current\ language = यो भाषामा गरेका परिवर्तन हरु सेभ नगरिकन अगाडी बढ्न चाहनु हुन्छ?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't actually pluralize as frequently in Nepali as we pluralize nouns in English.

api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
@binokaryg
Copy link
Member

Many missing translations are already there in one of our configs.
Example:

admin.message.queue =
admin.message.queue.created =
admin.message.queue.due =
admin.message.queue.error =
admin.message.queue.message =
admin.message.queue.recipient =
admin.message.queue.scheduled =
admin.message.queue.status =
admin.message.queue.tab.due =
admin.message.queue.tab.muted.future =
admin.message.queue.tab.muted.past =
admin.message.queue.tab.scheduled =
admin.message.queue.updated =
admin.message.queue.view.report =

@@ -112,9 +117,8 @@ Forms = फाराम
From = पठाउने
Full\ Name = पुरा नाम
Gateway\ number = मोडेमको नम्बर
Gateway\ number\ help = यहाँ मोडेममा राखिएको सिमको फोन नम्बर राख्नुहोला। यहि नम्बरमा रिपोर्ट तथा सन्देश पठाउनु पर्नेछ तथा यहि नम्बरबाट सन्देशहरु पठाइनेछन्।
Gateway\ number\ help = यहाँ मोडेममा राखिएको सिमको फोन नम्बर राख्नुहोला। यहि नम्बरमा रिपोर्ट तथा सन्देश पठाउनु पर्नेछ तथा यहि नम्बरबाट सन्देशहरू पठाइनेछन्।
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since other places have संदेश instead of सन्देश, shall we change this too?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1yuv this is the only comment I have. thanks.

Copy link

@nsitaula nsitaula Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1yuv I don't think this should be a blocker and is only related to consistency of word. So, approving the PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nsitaula , I totally missed this comment, thanks for pointing. I checked that सन्देश is accurate and that's in the nepali dictionary as well, so I've changed all refrences (up to 200Lines) to सन्देश.

@1yuv 1yuv requested review from binokaryg and nsitaula April 17, 2024 15:31
Copy link
Member

@binokaryg binokaryg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding/correcting the translations. Let's continue improving.

@1yuv 1yuv merged commit 64c60c0 into master Apr 19, 2024
34 checks passed
@1yuv 1yuv deleted the ne-translations branch April 19, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants