When ExperimentalPrimaryTeam is set then when a new user signsup with…

[csduarte]

Summary

This change joins new users to the default team if there's a team defined in config ExperimentalPrimaryTeam. This config assumes that new users will be part of this primary team.

When config to have a ExperimentalPrimaryTeam was added this change was pushed back pushed back.
https://github.com/mattermost/mattermost-server/pull/8039/files
#7846

cc @esethna @lindalumitchell @dmeza

[hmhealey]

Would you be able to add some unit tests for this behaviour?

Also, this looks like this will create the user successfully, but just return an error if it's unable to join the team for whatever reason. Would it be better to print the error in that case and still return that the user was created successfully?

[jasonblais]

@dmeza Did you have any questions about the above? We'd be more than happy to help.

[jasonblais]

@dmeza Did you have any questions about the above? We'd be more than happy to help.

[jasonblais]

Hey all,

Given we added a config setting for default teams, this change is no longer necessary. pr-mattermost-server-9068

#9068

You can now define a team to be both a default and primary team starting in v5.2.

The above PR I referenced was for default channels not default teams. So this PR is still valid.

[esethna]

Hi @dmeza. Just checking if there's anything we can help with to get this PR in?

[dmeza]

Hi @esethna, last time we discussed with @jasonblais, this PR was going to be closed. I see that the comment is that it's still valid. You can take over the PR since it's something that was used as a test but it's not part of shift.

[esethna]

Okay thanks. Adding @wiersgallak as this is related to work her team is doing

[jasonblais]

Will close for now given Shift only used it as a test. It can be resubmitted at a later time.