This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Fix bug when ExperimentalPrimaryTeam is set lastUrl does not work #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmeza
force-pushed
the
FixForLastUrlWhenExperimentalPrimaryTeamSet
branch
from
0a3629b
to
722c66d
Compare
crspeller
approved these changes
Feb 9, 2018
hmhealey
approved these changes
Feb 12, 2018
amyblais
added
Changelog/Not Needed
hmhealey
pushed a commit
that referenced
this pull request
Aug 28, 2020
* Spliting emojis and webhooks permissions * Keeping the old constants for backward compatibility
hmhealey
pushed a commit
that referenced
this pull request
Mar 17, 2021
* Spliting emojis and webhooks permissions * Keeping the old constants for backward compatibility
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is an issue were last channel is not being stored when you close the window. Every time you start it takes you to
Town Square. This is caused by the logic added with configExperimentalPrimaryTeam. This PR fixes the issue.#334
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passedvia @dmeza