This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Automated cherry pick of #9646 #9743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MM-40317: fixes showing new replies banner Currently we rely on the new messages line visibility on whether to show or not the "New Replies" banner. However new messages line is not showing, by design, on unfollowed threads. Which made the new replies banner to show when new replies arrived for those threads. This commit fixes the issue by guarding on the list's 'visibleStopIndex', if visibleStopIndex is zero then the last item of the list is visible. so we show the new replies only if the visibleStopIndex is not zero. * Removes unneeded change Co-authored-by: Mattermod <[email protected]> (cherry picked from commit 1e63c8a)
mattermod
added
AutomatedCherryPick
Changelog/Not Needed
amyblais
approved these changes
Feb 2, 2022
|
Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour. |
|
Trying to auto merge this PR. |
|
Pull Request successfully merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #9646 on release-6.3.
/cc @koox00