This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-40317: fixes showing new replies banner #9646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we rely on the new messages line visibility on whether to show or not the "New Replies" banner. However new messages line is not showing, by design, on unfollowed threads. Which made the new replies banner to show when new replies arrived for those threads. This commit fixes the issue by guarding on the list's 'visibleStopIndex', if visibleStopIndex is zero then the last item of the list is visible. so we show the new replies only if the visibleStopIndex is not zero.
|
/e2e-test |
|
Triggering e2e testing with options: |
|
Successfully triggered e2e testing! |
|
/update-branch |
jgilliam17
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
Thanks @koox00
Tested, looks good to merge.
- Verified
New Replies arrowappears when the new message is off the bottom of the rhs screen.
|
Test server destroyed |
|
/cherry-pick release-6.4 |
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
to mattermost-build/mattermost-webapp
that referenced
this pull request
Feb 2, 2022
* MM-40317: fixes showing new replies banner Currently we rely on the new messages line visibility on whether to show or not the "New Replies" banner. However new messages line is not showing, by design, on unfollowed threads. Which made the new replies banner to show when new replies arrived for those threads. This commit fixes the issue by guarding on the list's 'visibleStopIndex', if visibleStopIndex is zero then the last item of the list is visible. so we show the new replies only if the visibleStopIndex is not zero. * Removes unneeded change Co-authored-by: Mattermod <[email protected]> (cherry picked from commit 1e63c8a)
|
/cherry-pick release-6.3 |
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
to mattermost-build/mattermost-webapp
that referenced
this pull request
Feb 2, 2022
* MM-40317: fixes showing new replies banner Currently we rely on the new messages line visibility on whether to show or not the "New Replies" banner. However new messages line is not showing, by design, on unfollowed threads. Which made the new replies banner to show when new replies arrived for those threads. This commit fixes the issue by guarding on the list's 'visibleStopIndex', if visibleStopIndex is zero then the last item of the list is visible. so we show the new replies only if the visibleStopIndex is not zero. * Removes unneeded change Co-authored-by: Mattermod <[email protected]> (cherry picked from commit 1e63c8a)
mattermod
pushed a commit
that referenced
this pull request
Feb 2, 2022
mattermod
pushed a commit
that referenced
this pull request
Feb 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently we rely on the new messages line visibility on whether to show
or not the "New Replies" banner. However new messages line is not showing,
by design, on unfollowed threads. Which made the new replies banner to
show when new replies arrived for those threads.
This commit fixes the issue by guarding on the list's 'visibleStopIndex',
if visibleStopIndex is zero then the last item of the list is visible.
so we show the new replies only if the visibleStopIndex is not zero.
Ticket Link
https://mattermost.atlassian.net/browse/MM-40317
Release Note