Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-29393] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln 519 (#15832) #6694

Merged
merged 1 commit into from
Oct 13, 2020
Merged

[MM-29393] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln 519 (#15832) #6694

merged 1 commit into from
Oct 13, 2020

Conversation

KuSh
Copy link
Contributor

@KuSh KuSh commented Oct 8, 2020

Summary

Migrate changeCSS() to CSS variable in utils/utils.jsx, ln 519

Ticket Link

Fixes mattermost/mattermost#15832
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29393

@mattermod
Copy link
Contributor

Hello @KuSh,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@deanwhillier deanwhillier added hacktoberfest-accepted 2: Dev Review Requires review by a core commiter labels Oct 8, 2020
@deanwhillier
Copy link
Contributor

QA review will be done on the final PR that merges all changes to this campaign branch into master.

@esethna esethna requested review from nevyangelova and removed request for calebroseland October 8, 2020 20:02
@lindy65 lindy65 added the 3: QA Review Requires review by a QA tester label Oct 9, 2020
nevyangelova
nevyangelova reviewed Oct 9, 2020
View reviewed changes
Copy link
Contributor

@nevyangelova nevyangelova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you double check that the theme switch works in the new sidebar as well? Right now its only updated for the legacy sidebar.

@KuSh
Copy link
Contributor Author

KuSh commented Oct 9, 2020

Thanks! Can you double check that the theme switch works in the new sidebar as well? Right now its only updated for the legacy sidebar.

This is totally normal .sidebar--left class is only used by legacy sidebar so removed line in utils was only targeting legacy sidebar (and so is the migrated css rule)

@deanwhillier deanwhillier removed the 3: QA Review Requires review by a QA tester label Oct 13, 2020
@deanwhillier
Copy link
Contributor

PR will be QA'd in batch when campaign branch is merged to master

deanwhillier
deanwhillier approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@deanwhillier deanwhillier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KuSh, thanks for confirming for @nevyangelova!

@deanwhillier deanwhillier merged commit a9f2d6c into mattermost:campaign/applytheme_sidebar-text Oct 13, 2020
@KuSh KuSh deleted the issue/15832 branch October 13, 2020 19:56
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation and removed 2: Dev Review Requires review by a core commiter labels Oct 13, 2020
@deanwhillier deanwhillier mentioned this pull request Oct 14, 2020
Merged
deanwhillier added a commit that referenced this pull request Oct 16, 2020
@deanwhillier @KuSh @mattermod
Campaign/applytheme sidebar text (#6775)
4e05760 
* Remove an unused changeCSS() style (#6680)

Fixes mattermost/mattermost#15837
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29399

* [MM-29392] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 516 (#15831) (#6695)

Fixes mattermost/mattermost#15831
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29392

* [MM-29397] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln 525 (#15836) (#6686)

Remove the line as style is already applied unconditionally and more broadly by changeCss() call at line 515

Fixes mattermost/mattermost#15836
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29397

* [MM-29396] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 523 (#15835) (#6692)

Remove the line as it isn't possible that .sidebar__switcher button contains a svg

Fixes mattermost/mattermost#15835
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29396

* [MM-29391] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 513 (#15830) (#6696)

Fixes mattermost/mattermost#15830
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29391

* [MM-29393] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 519 (#15832) (#6694)

Fixes mattermost/mattermost#15832
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29393

* [MM-29394] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 520 (#15833) (#6693)

Fixes mattermost/mattermost#15833
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29394

Co-authored-by: Dean Whillier <[email protected]>

* Migrate changeCSS(sideText) to CSS variable --sidebartext in utils/utils.jsx (#6697)

* [MM-29389] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 510 (#15828)

This line was unconditionally replaced by line 824 using --link-color so I directly used --link-color in CSS

Fixes mattermost/mattermost#15828
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29389

* [MM-29390] Remove references to removed perfect-scrollbar component (#15829)

While analyzing mattermost/mattermost#15829 I couldn't found where ps-container class was used
It turns out it was an old dependency removed by PR #4382
This commit removes remaining references

Fixes mattermost/mattermost#15829
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29390

Co-authored-by: Nicolas Le Cam <[email protected]>
Co-authored-by: Mattermod <[email protected]>
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
@deanwhillier @KuSh
@mattermod @jfrerich
Campaign/applytheme sidebar text (#6775)
c9a16e0 
* Remove an unused changeCSS() style (#6680)

Fixes mattermost/mattermost#15837
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29399

* [MM-29392] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 516 (#15831) (#6695)

Fixes mattermost/mattermost#15831
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29392

* [MM-29397] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln 525 (#15836) (#6686)

Remove the line as style is already applied unconditionally and more broadly by changeCss() call at line 515

Fixes mattermost/mattermost#15836
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29397

* [MM-29396] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 523 (#15835) (#6692)

Remove the line as it isn't possible that .sidebar__switcher button contains a svg

Fixes mattermost/mattermost#15835
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29396

* [MM-29391] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 513 (#15830) (#6696)

Fixes mattermost/mattermost#15830
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29391

* [MM-29393] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 519 (#15832) (#6694)

Fixes mattermost/mattermost#15832
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29393

* [MM-29394] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 520 (#15833) (#6693)

Fixes mattermost/mattermost#15833
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29394

Co-authored-by: Dean Whillier <[email protected]>

* Migrate changeCSS(sideText) to CSS variable --sidebartext in utils/utils.jsx (#6697)

* [MM-29389] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 510 (#15828)

This line was unconditionally replaced by line 824 using --link-color so I directly used --link-color in CSS

Fixes mattermost/mattermost#15828
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29389

* [MM-29390] Remove references to removed perfect-scrollbar component (#15829)

While analyzing mattermost/mattermost#15829 I couldn't found where ps-container class was used
It turns out it was an old dependency removed by PR #4382
This commit removes remaining references

Fixes mattermost/mattermost#15829
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29390

Co-authored-by: Nicolas Le Cam <[email protected]>
Co-authored-by: Mattermod <[email protected]>
calebroseland pushed a commit that referenced this pull request Oct 27, 2020
@deanwhillier @KuSh
@mattermod @calebroseland
Campaign/applytheme sidebar text (#6775)
dd4dae4 
* Remove an unused changeCSS() style (#6680)

Fixes mattermost/mattermost#15837
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29399

* [MM-29392] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 516 (#15831) (#6695)

Fixes mattermost/mattermost#15831
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29392

* [MM-29397] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln 525 (#15836) (#6686)

Remove the line as style is already applied unconditionally and more broadly by changeCss() call at line 515

Fixes mattermost/mattermost#15836
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29397

* [MM-29396] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 523 (#15835) (#6692)

Remove the line as it isn't possible that .sidebar__switcher button contains a svg

Fixes mattermost/mattermost#15835
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29396

* [MM-29391] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 513 (#15830) (#6696)

Fixes mattermost/mattermost#15830
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29391

* [MM-29393] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 519 (#15832) (#6694)

Fixes mattermost/mattermost#15832
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29393

* [MM-29394] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 520 (#15833) (#6693)

Fixes mattermost/mattermost#15833
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29394

Co-authored-by: Dean Whillier <[email protected]>

* Migrate changeCSS(sideText) to CSS variable --sidebartext in utils/utils.jsx (#6697)

* [MM-29389] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 510 (#15828)

This line was unconditionally replaced by line 824 using --link-color so I directly used --link-color in CSS

Fixes mattermost/mattermost#15828
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29389

* [MM-29390] Remove references to removed perfect-scrollbar component (#15829)

While analyzing mattermost/mattermost#15829 I couldn't found where ps-container class was used
It turns out it was an old dependency removed by PR #4382
This commit removes remaining references

Fixes mattermost/mattermost#15829
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29390

Co-authored-by: Nicolas Le Cam <[email protected]>
Co-authored-by: Mattermod <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nevyangelova nevyangelova nevyangelova left review comments

@deanwhillier deanwhillier deanwhillier approved these changes

@asaadmahmood asaadmahmood asaadmahmood approved these changes

Assignees
No one assigned
Labels
Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
7 participants
@KuSh @mattermod @deanwhillier @asaadmahmood @nevyangelova @lindy65 @amyblais